From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932312AbbFWOsl (ORCPT <rfc822;w@1wt.eu>);
	Tue, 23 Jun 2015 10:48:41 -0400
Received: from comal.ext.ti.com ([198.47.26.152]:35289 "EHLO comal.ext.ti.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753848AbbFWOsc (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 23 Jun 2015 10:48:32 -0400
Date: Tue, 23 Jun 2015 17:47:23 +0300
From: Roger Quadros <rogerq@ti.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
CC: <bcousson@baylibre.com>, <tony@atomide.com>, <balbi@ti.com>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-omap@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
        <linux-usb@vger.kernel.org>, <robh+dt@kernel.org>,
        <pawel.moll@arm.com>, <mark.rutland@arm.com>,
        <ijc+devicetree@hellion.org.uk>, <galak@codeaurora.org>,
        <linux@arm.linux.org.uk>, <gregkh@linuxfoundation.org>,
        <nsekhar@ti.com>
Subject: Re: [PATCH 01/17] phy: ti-pipe3: use ti_pipe3_power_off to power
 off the PHY during probe
Message-ID: <20150623174723.f6d28a668421d6c16289770f@ti.com>
In-Reply-To: <1435060743-5511-2-git-send-email-kishon@ti.com>
References: <1435060743-5511-1-git-send-email-kishon@ti.com>
	<1435060743-5511-2-git-send-email-kishon@ti.com>
X-Mailer: Sylpheed 3.4.2 (GTK+ 2.24.27; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 23 Jun 2015 17:28:46 +0530
Kishon Vijay Abraham I <kishon@ti.com> wrote:

> No functional change. Previously omap_control_phy_power() was used to power
> off the PHY during probe. But once PIPE3 driver is adapted to use syscon,
> omap_control_phy_power() cannot be used. Hence used ti_pipe3_power_off
> to power off the PHY.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>

Acked-by: Roger Quadros <rogerq@ti.com>

cheers,
-roger

> ---
>  drivers/phy/phy-ti-pipe3.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/phy/phy-ti-pipe3.c b/drivers/phy/phy-ti-pipe3.c
> index 08020dc..d784426 100644
> --- a/drivers/phy/phy-ti-pipe3.c
> +++ b/drivers/phy/phy-ti-pipe3.c
> @@ -431,8 +431,6 @@ static int ti_pipe3_probe(struct platform_device *pdev)
>  
>  	phy->control_dev = &control_pdev->dev;
>  
> -	omap_control_phy_power(phy->control_dev, 0);
> -
>  	platform_set_drvdata(pdev, phy);
>  	pm_runtime_enable(phy->dev);
>  
> @@ -451,6 +449,8 @@ static int ti_pipe3_probe(struct platform_device *pdev)
>  		return PTR_ERR(generic_phy);
>  
>  	phy_set_drvdata(generic_phy, phy);
> +	ti_pipe3_power_off(generic_phy);
> +
>  	phy_provider = devm_of_phy_provider_register(phy->dev,
>  			of_phy_simple_xlate);
>  	if (IS_ERR(phy_provider))
> -- 
> 1.7.9.5
>