From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751341AbbFXIc4 (ORCPT ); Wed, 24 Jun 2015 04:32:56 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:39195 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750770AbbFXIcu (ORCPT ); Wed, 24 Jun 2015 04:32:50 -0400 Date: Wed, 24 Jun 2015 01:44:40 -0700 (PDT) Message-Id: <20150624.014440.1731894598101096619.davem@davemloft.net> To: Alexey.Brodkin@synopsys.com Cc: netdev@vger.kernel.org, peppe.cavallaro@st.com, arc-linux-dev@synopsys.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] stmmac: troubleshoot unexpected bits in des0 & des1 From: David Miller In-Reply-To: <1435133246-15776-1-git-send-email-abrodkin@synopsys.com> References: <20150624.001840.1867851321247997506.davem@davemloft.net> <1435133246-15776-1-git-send-email-abrodkin@synopsys.com> X-Mailer: Mew version 6.4 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 24 Jun 2015 01:32:49 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alexey Brodkin Date: Wed, 24 Jun 2015 11:07:26 +0300 > > - priv->dma_tx = dma_alloc_coherent(priv->device, txsize * > + priv->dma_tx = dma_zalloc_coherent(priv->device, txsize * > sizeof(struct dma_desc), > &priv->dma_tx_phy, > GFP_KERNEL); When you change the column at which the openning parenthesis of the function call occurs, you must indent the subsequent lines of the function call such that the all are adjusted to properly start at the very next column after that openning parenthesis.' Please fix this up for all of the dma_zalloc_coherent() transformations. Thanks.