From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752815AbbFXMIm (ORCPT <rfc822;w@1wt.eu>);
	Wed, 24 Jun 2015 08:08:42 -0400
Received: from arroyo.ext.ti.com ([192.94.94.40]:43119 "EHLO arroyo.ext.ti.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752772AbbFXMIk (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 24 Jun 2015 08:08:40 -0400
Date: Wed, 24 Jun 2015 15:07:50 +0300
From: Roger Quadros <rogerq@ti.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
CC: <bcousson@baylibre.com>, <tony@atomide.com>, <balbi@ti.com>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-omap@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
        <linux-usb@vger.kernel.org>, <robh+dt@kernel.org>,
        <pawel.moll@arm.com>, <mark.rutland@arm.com>,
        <ijc+devicetree@hellion.org.uk>, <galak@codeaurora.org>,
        <linux@arm.linux.org.uk>, <gregkh@linuxfoundation.org>,
        <nsekhar@ti.com>
Subject: Re: [PATCH 11/17] ARM: dts: dra7: Use "ti,dra7x-usb2-phy2"
 compatible string for USB2 PHY2
Message-ID: <20150624150750.9435096c85253cfe528ebbc3@ti.com>
In-Reply-To: <1435060743-5511-12-git-send-email-kishon@ti.com>
References: <1435060743-5511-1-git-send-email-kishon@ti.com>
	<1435060743-5511-12-git-send-email-kishon@ti.com>
X-Mailer: Sylpheed 3.4.2 (GTK+ 2.24.27; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 23 Jun 2015 17:28:56 +0530
Kishon Vijay Abraham I <kishon@ti.com> wrote:

> The USB2 PHY2 has a different register map compared to USB2 PHY1
> to power on/off the PHY. In order to handle it, use the new compatible
> string "ti,dra7x-usb2-phy2" for the second instance of USB2 PHY.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>  arch/arm/boot/dts/dra7.dtsi |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> index f69db70..a8ee829 100644
> --- a/arch/arm/boot/dts/dra7.dtsi
> +++ b/arch/arm/boot/dts/dra7.dtsi
> @@ -1235,7 +1235,7 @@
>  			};
>  
>  			usb2_phy2: phy@4a085000 {
> -				compatible = "ti,omap-usb2";
> +				compatible = "ti,dra7x-usb2-phy2", "ti,omap-usb2";

Why do you want to retain "ti,omap-usb2".
It is not backward compatible with it right?

>  				reg = <0x4a085000 0x400>;
>  				ctrl-module = <&omap_control_usb2phy2>;
>  				clocks = <&usb_phy2_always_on_clk32k>,
> -- 
> 1.7.9.5
> 

cheers,
-roger