From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752852AbbFXMOG (ORCPT <rfc822;w@1wt.eu>);
	Wed, 24 Jun 2015 08:14:06 -0400
Received: from bear.ext.ti.com ([192.94.94.41]:49404 "EHLO bear.ext.ti.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752081AbbFXMNz (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 24 Jun 2015 08:13:55 -0400
Date: Wed, 24 Jun 2015 15:12:57 +0300
From: Roger Quadros <rogerq@ti.com>
To: Roger Quadros <rogerq@ti.com>
CC: Kishon Vijay Abraham I <kishon@ti.com>, <bcousson@baylibre.com>,
        <tony@atomide.com>, <balbi@ti.com>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <linux-usb@vger.kernel.org>,
        <robh+dt@kernel.org>, <pawel.moll@arm.com>, <mark.rutland@arm.com>,
        <ijc+devicetree@hellion.org.uk>, <galak@codeaurora.org>,
        <linux@arm.linux.org.uk>, <gregkh@linuxfoundation.org>,
        <nsekhar@ti.com>
Subject: Re: [PATCH 09/17] ARM: dts: dra7: Use "syscon-phy-power" instead of
 "ctrl-module" in SATA PHY node
Message-ID: <20150624151257.fe5f1594db1afe4c1da8027d@ti.com>
In-Reply-To: <20150624150602.0e73fc8f9dda1624f22059db@ti.com>
References: <1435060743-5511-1-git-send-email-kishon@ti.com>
	<1435060743-5511-10-git-send-email-kishon@ti.com>
	<20150624150602.0e73fc8f9dda1624f22059db@ti.com>
X-Mailer: Sylpheed 3.4.2 (GTK+ 2.24.27; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 24 Jun 2015 15:06:02 +0300
Roger Quadros <rogerq@ti.com> wrote:

> On Tue, 23 Jun 2015 17:28:54 +0530
> Kishon Vijay Abraham I <kishon@ti.com> wrote:
> 
> > Add "syscon-phy-power" property and remove the deprecated "ctrl-module"
> > property from SATA PHY node. Since "omap_control_sata" note is no longer
> > used, remove it.
> > 
> > Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> 
> Acked-by: Roger Quadros <rogerq@ti.com>

One comment though.

> 
> > ---
> >  arch/arm/boot/dts/dra7.dtsi |   10 +---------
> >  1 file changed, 1 insertion(+), 9 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> > index 3f434f7..92e0741 100644
> > --- a/arch/arm/boot/dts/dra7.dtsi
> > +++ b/arch/arm/boot/dts/dra7.dtsi
> > @@ -1115,14 +1115,6 @@
> >  			status = "disabled";
> >  		};
> >  
> > -		omap_control_sata: control-phy@4a002374 {
> > -			compatible = "ti,control-phy-pipe3";
> > -			reg = <0x4a002374 0x4>;
> > -			reg-names = "power";
> > -			clocks = <&sys_clkin1>;
> > -			clock-names = "sysclk";
> > -		};
> > -
> >  		/* OCP2SCP3 */
> >  		ocp2scp@4a090000 {
> >  			compatible = "ti,omap-ocp2scp";
> > @@ -1137,7 +1129,7 @@
> >  				      <0x4A096400 0x64>, /* phy_tx */
> >  				      <0x4A096800 0x40>; /* pll_ctrl */
> >  				reg-names = "phy_rx", "phy_tx", "pll_ctrl";
> > -				ctrl-module = <&omap_control_sata>;
> > +				syscon-phy-power = <&dra7_ctrl_core 0x374>;

why can't we use scm_conf instead of dra7_ctrl_core?
dra7_ctrl_core seems to be redundant and wrongly placed.

> >  				clocks = <&sys_clkin1>, <&sata_ref_clk>;
> >  				clock-names = "sysclk", "refclk";
> >  				syscon-pllreset = <&dra7_ctrl_core 0x3fc>;
> > -- 
> > 1.7.9.5
> > 

cheers,
-roger