From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753493AbbFXNvD (ORCPT ); Wed, 24 Jun 2015 09:51:03 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:50001 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752808AbbFXNu7 (ORCPT ); Wed, 24 Jun 2015 09:50:59 -0400 Date: Wed, 24 Jun 2015 16:50:08 +0300 From: Roger Quadros To: Kishon Vijay Abraham I CC: , , , , , , , , , , , , , , , Subject: Re: [PATCH 11/17] ARM: dts: dra7: Use "ti,dra7x-usb2-phy2" compatible string for USB2 PHY2 Message-ID: <20150624165008.36bed5c058fa4f43e7748c5c@ti.com> In-Reply-To: <558AAC47.2070305@ti.com> References: <1435060743-5511-1-git-send-email-kishon@ti.com> <1435060743-5511-12-git-send-email-kishon@ti.com> <20150624150750.9435096c85253cfe528ebbc3@ti.com> <558AAC47.2070305@ti.com> X-Mailer: Sylpheed 3.4.2 (GTK+ 2.24.27; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 24 Jun 2015 18:40:31 +0530 Kishon Vijay Abraham I wrote: > Hi, > > On Wednesday 24 June 2015 05:37 PM, Roger Quadros wrote: > > On Tue, 23 Jun 2015 17:28:56 +0530 > > Kishon Vijay Abraham I wrote: > > > >> The USB2 PHY2 has a different register map compared to USB2 PHY1 > >> to power on/off the PHY. In order to handle it, use the new compatible > >> string "ti,dra7x-usb2-phy2" for the second instance of USB2 PHY. > >> > >> Signed-off-by: Kishon Vijay Abraham I > >> --- > >> arch/arm/boot/dts/dra7.dtsi | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi > >> index f69db70..a8ee829 100644 > >> --- a/arch/arm/boot/dts/dra7.dtsi > >> +++ b/arch/arm/boot/dts/dra7.dtsi > >> @@ -1235,7 +1235,7 @@ > >> }; > >> > >> usb2_phy2: phy@4a085000 { > >> - compatible = "ti,omap-usb2"; > >> + compatible = "ti,dra7x-usb2-phy2", "ti,omap-usb2"; > > > > Why do you want to retain "ti,omap-usb2". > > It is not backward compatible with it right? > > The newer dtbs will anyway have "ti,dra7x-usb2-phy2", so "ti,omap-usb2" was > kept just for legacy reasons. OK then. cheers, -roger