From: Peter Zijlstra <peterz@infradead.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
John Stultz <john.stultz@linaro.org>,
Steven Rostedt <rostedt@goodmis.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Nicolas Pitre <nicolas.pitre@linaro.org>
Subject: Re: [PATCH] ARM64: smp: Silence suspicious RCU usage with ipi tracepoints
Date: Wed, 24 Jun 2015 23:29:30 +0200 [thread overview]
Message-ID: <20150624212930.GC12596@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1435176858-9568-1-git-send-email-sboyd@codeaurora.org>
On Wed, Jun 24, 2015 at 01:14:18PM -0700, Stephen Boyd wrote:
> John Stultz reported an RCU splat on ARM with ipi trace events
> enabled. It looks like the same problem exists on ARM64.
>
> At this point in the IPI handling path we haven't called
> irq_enter() yet, so RCU doesn't know that we're about to exit
> idle and properly warns that we're using RCU from an idle CPU.
> Use trace_ipi_entry_rcuidle() instead of trace_ipi_entry() so
> that RCU is informed about our exit from idle.
I have a problem with $subject. It says 'silence', whereas afaict this
fixes an actual bug, so it should be 'fixes'.
next prev parent reply other threads:[~2015-06-24 21:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-24 20:14 Stephen Boyd
2015-06-24 20:20 ` Paul E. McKenney
2015-06-24 21:29 ` Peter Zijlstra [this message]
2015-06-24 21:59 ` Stephen Boyd
2015-06-25 13:24 ` Catalin Marinas
2015-06-25 1:01 ` Steven Rostedt
2015-06-29 10:02 ` Russell King - ARM Linux
2015-06-29 11:23 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150624212930.GC12596@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=catalin.marinas@arm.com \
--cc=john.stultz@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
--cc=sboyd@codeaurora.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome