From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752078AbbFYNVs (ORCPT ); Thu, 25 Jun 2015 09:21:48 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:47672 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751313AbbFYNVi (ORCPT ); Thu, 25 Jun 2015 09:21:38 -0400 Date: Thu, 25 Jun 2015 06:33:31 -0700 (PDT) Message-Id: <20150625.063331.1437042913073267200.davem@davemloft.net> To: geert@linux-m68k.org Cc: tom@herbertland.com, jiri@resnulli.us, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] flow_dissector: Pre-initialize ip_proto in __skb_flow_dissect() From: David Miller In-Reply-To: <1435237832-28838-1-git-send-email-geert@linux-m68k.org> References: <1435237832-28838-1-git-send-email-geert@linux-m68k.org> X-Mailer: Mew version 6.4 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-7 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 25 Jun 2015 06:21:38 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t5PDLrlo023919 From: Geert Uytterhoeven Date: Thu, 25 Jun 2015 15:10:32 +0200 > net/core/flow_dissector.c: In function __skb_flow_dissect: > net/core/flow_dissector.c:132: warning: ip_proto may be used uninitialized in this function > > Signed-off-by: Geert Uytterhoeven > --- > This may be a false positive, but the state machine in > __skb_flow_dissect() is a bit hard to follow. > As I believe it is controlled by a packet received from the network, the > only safe thing to do is to pre-initialize ip_proto. Actually I think this is a real bug, because for the ETH_P_MPLS_* cases I cannot see what will always set ip_proto before it gets used as an input. {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I