From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751340AbbFYGsi (ORCPT ); Thu, 25 Jun 2015 02:48:38 -0400 Received: from mail.kernel.org ([198.145.29.136]:36067 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750919AbbFYGs3 (ORCPT ); Thu, 25 Jun 2015 02:48:29 -0400 Date: Wed, 24 Jun 2015 23:48:26 -0700 From: Jaegeuk Kim To: Al Viro Cc: Linus Torvalds , Linux Kernel Mailing List , Linux FS Dev Mailing List , Linux F2FS Dev Mailing List , Stephen Rothwell Subject: Re: [GIT PULL] f2fs updates for v4.2 Message-ID: <20150625064522.GA44674@jaegeuk-mac02.mot-mobility.com> References: <20150624202401.GA40031@jaegeuk-mac02.mot.com> <20150625043334.GT17109@ZenIV.linux.org.uk> <20150625054917.GA43469@jaegeuk-mac02.hsd1.ca.comcast.net> <20150625063235.GV17109@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150625063235.GV17109@ZenIV.linux.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 25, 2015 at 07:32:36AM +0100, Al Viro wrote: > On Wed, Jun 24, 2015 at 10:50:10PM -0700, Jaegeuk Kim wrote: > > > Right, I missed merging the fix-up patch in linux-next into my pull-request. > > At a glance, I think there is no problem; except 80 column width, though. > > > > Also, agreed that I need to take a look at deleting the dentry to deal with that > > failure case. > > Why not set the symlink up first and create a directory entry only > if that succeeds? Looks like it's less work that way... Cause f2fs_add_link initializes some on-disk inode structures to be used when writing data. Maybe simply call f2fs_unlink?