From: Peter Zijlstra <peterz@infradead.org>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
Cong Wang <cwang@twopensource.com>
Subject: Re: [PATCH] sched: split sched_switch trace event into two
Date: Thu, 25 Jun 2015 09:48:17 +0200 [thread overview]
Message-ID: <20150625074817.GV3644@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1435187973-23931-1-git-send-email-xiyou.wangcong@gmail.com>
On Wed, Jun 24, 2015 at 04:19:33PM -0700, Cong Wang wrote:
> Currently we only have one sched_switch trace event
> for task switching, which is generated very early during
> task switch. When we try to monitor per-container events,
> this is not what we expect.
Adjust your expectations?
> For example, we have a process A which is in the cgroup
> we monitor, and process B which isn't, when kernel switches
> from B to A, the sched_switch event is not recorded for this
> cgroup since it belongs to B (current process is still B
> util we finish the switch), but we require this event to
> signal that process A in this cgroup gets scheduled. This is
> crucial for calculating schedule latency.
I don't get it. This is global data in the root pid-space.
The switch data includes both the previous and the next task. Just look
up their corresponding cgroups and be done with it.
If you cannot get what you want from it, you're doing it wrong.
next prev parent reply other threads:[~2015-06-25 7:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-24 23:19 Cong Wang
2015-06-25 1:05 ` Steven Rostedt
2015-06-25 17:04 ` Cong Wang
2015-06-25 7:48 ` Peter Zijlstra [this message]
2015-06-25 17:17 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150625074817.GV3644@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=cwang@twopensource.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®