From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Jeff Chua <jeff.chua.linux@gmail.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: Stop SSD from waiting for "Spinning up disk..."
Date: Thu, 25 Jun 2015 13:21:43 -0300 [thread overview]
Message-ID: <20150625162143.GA27230@khazad-dum.debian.net> (raw)
In-Reply-To: <Pine.LNX.4.64.1506221521480.7601@boston.corp.fedex.com>
On Mon, 22 Jun 2015, Jeff Chua wrote:
> There's no need to wait for disk spin-up for USB SSD devices. This patch
No, you have to, instead, wait for SSD firmware startup.
And looking at the contents of sd_spinup_disk(), I don't think it is safe to
just skip it, either. It would be be better to call it sd_start_device()...
sd_spinup_disk() should be really fast on anything that properly implements
TEST_UNIT_READY and returns "ok, I am ready" when it doesn't need further
waits or START_STOP, etc...
Anyway, if you get to see the "Spinning up disk..." printk, your unit did
not report it was ready, and sd_spinup_disk tried to issue a START_STOP
command to signal it to get ready for real work.
There's at least one msleep(1000) in the START_STOP path, though.
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
next prev parent reply other threads:[~2015-06-25 16:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-22 7:25 Jeff Chua
2015-06-22 15:36 ` Greg Kroah-Hartman
2015-06-23 15:02 ` Jeff Chua
2015-06-23 18:27 ` Frans Klaver
2015-06-23 18:51 ` Marc Burkhardt
2015-06-25 16:21 ` Henrique de Moraes Holschuh [this message]
2015-06-25 16:47 ` Joe Perches
2015-06-23 18:26 Andreas Mohr
2015-06-23 18:55 ` Martin Steigerwald
2015-06-24 16:22 ` Jeff Chua
2015-06-24 16:28 ` Greg Kroah-Hartman
2015-06-24 23:55 ` Jeff Chua
2015-06-25 1:41 ` Greg Kroah-Hartman
2015-06-25 6:08 ` Martin Steigerwald
2015-06-25 8:52 ` Jeff Chua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150625162143.GA27230@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=jeff.chua.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®