From: Luis de Bethencourt <luis@debethencourt.com>
To: Daniel Grimshaw <grimshaw@linux.vnet.ibm.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
gregkh@linuxfoundation.org, benchan@chromium.org,
rafael.j.wysocki@intel.com, tj@kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
trivial@kernel.org
Subject: Re: [PATCH] staging: gdm72xx: Split Kconfig descriptions into more lines
Date: Fri, 26 Jun 2015 13:29:41 +0200 [thread overview]
Message-ID: <20150626112938.GA19389@goodgumbo.baconseed.org> (raw)
In-Reply-To: <558C827E.1020105@linux.vnet.ibm.com>
On Thu, Jun 25, 2015 at 03:36:46PM -0700, Daniel Grimshaw wrote:
> I am a high school student trying to become familiar with linux kernel
> development. This is my first patch.
>
> checkpatch.pl throws a warning that config WIMAX_GDM72XX_QOS, config
> WIMAX_GDM72XX_K_MODE, and config WIMAX_GDM72XX_USB do not have enough
> of a description. By splitting the current description into multiple
> lines, the warning is removed.
>
> The module still worked with these changes when tested.
>
> Signed-off-by: Daniel Grimshaw <grimshaw@linux.vnet.ibm.com>
>
Hello Daniel,
Nice to see people submitting their first patch. Welcome :)
Besides what Dan Carpenter said, I wanted to add a comment about how to send
patches. Normally maintainers don't accept patches as attachments. You want to
send the patch inline.
I recommend these two resources to learn how:
http://kernelnewbies.org/FirstKernelPatch
Greg's talk "Write and Submit your first Linux kernel Patch"
- https://www.youtube.com/watch?v=LLBrBBImJt4
There is a bit of a learning curve. It is normal to not get it right the first
time. Feel free to email me directly with any further questions about this.
Happy hacking,
Luis
prev parent reply other threads:[~2015-06-26 11:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 22:36 Daniel Grimshaw
2015-06-26 7:37 ` Dan Carpenter
2015-06-26 11:29 ` Luis de Bethencourt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150626112938.GA19389@goodgumbo.baconseed.org \
--to=luis@debethencourt.com \
--cc=benchan@chromium.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=grimshaw@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=tj@kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®