mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org,
	cgroups@vger.kernel.org, avanzini.arianna@gmail.com,
	kernel-team@fb.com
Subject: Re: [PATCH 2/6] blkcg: add blkg_[rw]stat->aux_cnt and replace cfq_group->dead_stats with it
Date: Fri, 26 Jun 2015 09:45:25 -0400	[thread overview]
Message-ID: <20150626134525.GB14803@redhat.com> (raw)
In-Reply-To: <20150626133540.GA15805@mtj.duckdns.org>

On Fri, Jun 26, 2015 at 09:35:40AM -0400, Tejun Heo wrote:
> On Fri, Jun 26, 2015 at 09:27:02AM -0400, Vivek Goyal wrote:
> > On Thu, Jun 25, 2015 at 05:38:53PM -0400, Tejun Heo wrote:
> > 
> > [..]
> > > It's planned that the core stats will be moved to blkcg_gq, so we want
> > > to move the mechanism for keeping track of the stats of dead children
> > > from cfq to blkcg core.  This patch adds blkg_[rw]stat->aux_cnt which
> > > are atomic64_t's keeping track of auxiliary counts which are excluded
> > > when reading local counts but included for recursive.
> > 
> > Hi Tejun,
> > 
> > So aux_cnt is atomic64_t as updation is not the hot path hence there is
> > not much value in keeping it as per cpu?
> 
> I'm not following.  aux_cnt isn't per-cpu.

I was just curious that why aux_cnt is different from rest of the stats.
(It is atomic64_t while others are not).

Thanks
Vivek

  reply	other threads:[~2015-06-26 13:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-25 21:38 [PATCHSET block/for-4.2/writeback] blkcg: blkcg stats cleanup Tejun Heo
2015-06-25 21:38 ` [PATCH 1/6] cgroup: make cftype->private a unsigned long Tejun Heo
2015-06-30  6:50   ` Zefan Li
2015-06-25 21:38 ` [PATCH 2/6] blkcg: add blkg_[rw]stat->aux_cnt and replace cfq_group->dead_stats with it Tejun Heo
2015-06-26 13:27   ` Vivek Goyal
2015-06-26 13:35     ` Tejun Heo
2015-06-26 13:45       ` Vivek Goyal [this message]
2015-06-26 13:55         ` Tejun Heo
2015-06-25 21:38 ` [PATCH 3/6] blkcg: make blkcg_[rw]stat per-cpu Tejun Heo
2015-06-25 21:38 ` [PATCH 4/6] blkcg: make blkg_[rw]stat_recursive_sum() to be able to index into blkcg_gq Tejun Heo
2015-06-25 21:38 ` [PATCH 5/6] blkcg: move io_service_bytes and io_serviced stats " Tejun Heo
2015-06-26 16:01   ` Vivek Goyal
2015-06-26 16:09     ` Tejun Heo
2015-06-25 21:38 ` [PATCH 6/6] blkcg: remove cfqg_stats->sectors Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150626134525.GB14803@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=avanzini.arianna@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=cgroups@vger.kernel.org \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome