mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hans-Christian Egtvedt <egtvedt@samfundet.no>
To: rmk+kernel@arm.linux.org.uk, hskinnemoen@gmail.com,
	hpa@zytor.com, mingo@kernel.org, tglx@linutronix.de,
	Julia.Lawall@lip6.fr, linux-kernel@vger.kernel.org
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:irq/urgent] avr32/at32ap: Fix race in installing chained IRQ handler
Date: Sun, 28 Jun 2015 20:15:29 +0200	[thread overview]
Message-ID: <20150628181529.GB8046@samfundet.no> (raw)
In-Reply-To: <tip-bf54da7d3a49d3359574cdc1590bbc79ee19be6a@git.kernel.org>

Around Fri 26 Jun 2015 12:47:18 -0700 or thereabout, tip-bot for Thomas Gleixner wrote:
> avr32/at32ap: Fix race in installing chained IRQ handler
> 

<snipp>


> Reported-by: Russell King <rmk+kernel@arm.linux.org.uk>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Julia Lawall <Julia.Lawall@lip6.fr>
> Cc: Haavard Skinnemoen <hskinnemoen@gmail.com>
> Cc: Hans-Christian Egtvedt <egtvedt@samfundet.no>
> ---
>  arch/avr32/mach-at32ap/extint.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/avr32/mach-at32ap/extint.c b/arch/avr32/mach-at32ap/extint.c
> index cfb298d..2d48b6a 100644
> --- a/arch/avr32/mach-at32ap/extint.c
> +++ b/arch/avr32/mach-at32ap/extint.c
> @@ -231,8 +231,7 @@ static int __init eic_probe(struct platform_device *pdev)
>  		irq_set_chip_data(eic->first_irq + i, eic);
>  	}
>  
> -	irq_set_chained_handler(int_irq, demux_eic_irq);
> -	irq_set_handler_data(int_irq, eic);
> +	irq_set_chained_handler_and_data(int_irq, demux_eic_irq, eic);
>  
>  	if (pdev->id == 0) {
>  		nmi_eic = eic;

Good fix, wil you pass it through your git tree, or would you prefer I add it
to the AVR32 tree? I have nothing in the pipe, hence feel free to add it to a
series if you are preparing fixes.

Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>

-- 
mvh
Hans-Christian Egtvedt

           reply	other threads:[~2015-06-28 18:16 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <tip-bf54da7d3a49d3359574cdc1590bbc79ee19be6a@git.kernel.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150628181529.GB8046@samfundet.no \
    --to=egtvedt@samfundet.no \
    --cc=Julia.Lawall@lip6.fr \
    --cc=hpa@zytor.com \
    --cc=hskinnemoen@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®