From: Michal Hocko <mhocko@suse.cz>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: hannes@cmpxchg.org, cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm:Make the function alloc_mem_cgroup_per_zone_info bool
Date: Mon, 29 Jun 2015 17:36:24 +0200 [thread overview]
Message-ID: <20150629153623.GC4617@dhcp22.suse.cz> (raw)
In-Reply-To: <3320C010-248A-4296-A5E4-30D9E7B3E611@gmail.com>
On Mon 29-06-15 11:23:08, Nicholas Krause wrote:
[...]
> I agree with and looked into the callers about this wasn't sure if you
> you wanted me to return - ENOMEM. I will rewrite this patch the other
> way.
I am not sure this path really needs a cleanup.
> Furthermore I apologize about this and do have actual useful
> patches but will my rep it's hard to get replies from maintainers.
You can hardly expect somebody will be thrilled about your patches when
their fault rate is close to 100%. Reviewing each patch takes time and
that is a scarce resource. If you want people to follow your patches
make sure you are offering something that might be interesting or
useful. Cleanups like these usually are not interesting without
either building something bigger on top of them or when they improve
readability considerably.
[...]
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2015-06-29 15:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1435587233-27976-1-git-send-email-xerofoify@gmail.com>
2015-06-29 15:03 ` Michal Hocko
[not found] ` <3320C010-248A-4296-A5E4-30D9E7B3E611@gmail.com>
2015-06-29 15:36 ` Michal Hocko [this message]
[not found] ` <559167D8.80803@gmail.com>
2015-06-29 15:55 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150629153623.GC4617@dhcp22.suse.cz \
--to=mhocko@suse.cz \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®