From: Greg KH <greg@kroah.com>
To: Jeremy White <jwhite@codeweavers.com>
Cc: hdegoede@redhat.com, spice-devel@lists.freedesktop.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect USB devices over IP.
Date: Tue, 30 Jun 2015 16:48:05 -0700 [thread overview]
Message-ID: <20150630234805.GB13573@kroah.com> (raw)
In-Reply-To: <1435700650-640-2-git-send-email-jwhite@codeweavers.com>
On Tue, Jun 30, 2015 at 04:44:10PM -0500, Jeremy White wrote:
> This module uses the usbredir protocol and user space tools,
> which are used by the SPICE project.
>
> Signed-off-by: Jeremy White <jwhite@codeweavers.com>
> ---
> MAINTAINERS | 6 +
> drivers/usb/Kconfig | 2 +
> drivers/usb/Makefile | 1 +
> drivers/usb/usbredir/Kconfig | 25 +
> drivers/usb/usbredir/Makefile | 4 +
> drivers/usb/usbredir/README | 20 +
> drivers/usb/usbredir/TODO | 12 +
> drivers/usb/usbredir/device.c | 327 +++++
> drivers/usb/usbredir/hub.c | 489 ++++++++
> drivers/usb/usbredir/main.c | 100 ++
> drivers/usb/usbredir/redir.c | 535 ++++++++
> drivers/usb/usbredir/rx.c | 40 +
> drivers/usb/usbredir/strtok_r.c | 69 +
> drivers/usb/usbredir/strtok_r.h | 26 +
> drivers/usb/usbredir/sysfs.c | 145 +++
> drivers/usb/usbredir/tx.c | 151 +++
> drivers/usb/usbredir/urb.c | 266 ++++
> drivers/usb/usbredir/usbredir.h | 225 ++++
> drivers/usb/usbredir/usbredirfilter.c | 294 +++++
> drivers/usb/usbredir/usbredirfilter.h | 144 +++
> drivers/usb/usbredir/usbredirparser.c | 1795 +++++++++++++++++++++++++++
> drivers/usb/usbredir/usbredirparser.h | 386 ++++++
> drivers/usb/usbredir/usbredirproto-compat.h | 88 ++
> drivers/usb/usbredir/usbredirproto.h | 309 +++++
> 24 files changed, 5459 insertions(+)
> create mode 100644 drivers/usb/usbredir/Kconfig
> create mode 100644 drivers/usb/usbredir/Makefile
> create mode 100644 drivers/usb/usbredir/README
> create mode 100644 drivers/usb/usbredir/TODO
> create mode 100644 drivers/usb/usbredir/device.c
> create mode 100644 drivers/usb/usbredir/hub.c
> create mode 100644 drivers/usb/usbredir/main.c
> create mode 100644 drivers/usb/usbredir/redir.c
> create mode 100644 drivers/usb/usbredir/rx.c
> create mode 100644 drivers/usb/usbredir/strtok_r.c
> create mode 100644 drivers/usb/usbredir/strtok_r.h
> create mode 100644 drivers/usb/usbredir/sysfs.c
> create mode 100644 drivers/usb/usbredir/tx.c
> create mode 100644 drivers/usb/usbredir/urb.c
> create mode 100644 drivers/usb/usbredir/usbredir.h
> create mode 100644 drivers/usb/usbredir/usbredirfilter.c
> create mode 100644 drivers/usb/usbredir/usbredirfilter.h
> create mode 100644 drivers/usb/usbredir/usbredirparser.c
> create mode 100644 drivers/usb/usbredir/usbredirparser.h
> create mode 100644 drivers/usb/usbredir/usbredirproto-compat.h
> create mode 100644 drivers/usb/usbredir/usbredirproto.h
It's pointless to post a patch that you know has problems with it (i.e.
it's not even in proper kernel coding style), as it will never be
reviewed or even looked at.
Please do the most basic of polite things and fix this up before posting
things.
And really, all in one patch? That too is pretty hard to review...
thanks,
greg k-h
next prev parent reply other threads:[~2015-06-30 23:48 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 21:44 [RFC PATCH 0/1] RFC - Implement a usbredir kernel module Jeremy White
2015-06-30 21:44 ` [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect USB devices over IP Jeremy White
2015-06-30 23:48 ` Greg KH [this message]
2015-07-01 3:34 ` Jeremy White
2015-07-01 5:44 ` Greg KH
2015-07-01 15:55 ` Jeremy White
2015-07-01 16:13 ` Greg KH
2015-07-01 18:39 ` Hans de Goede
2015-07-07 16:47 ` Jeremy White
2015-07-08 7:11 ` Hans de Goede
2015-07-09 0:19 ` Jeremy White
2015-07-01 9:06 ` [Spice-devel] " Daniel P. Berrange
2015-07-01 18:31 ` Jeremy White
2015-07-01 18:45 ` Hans de Goede
2015-07-02 8:45 ` Oliver Neukum
2015-07-02 11:35 ` Hans de Goede
2015-07-02 12:10 ` Oliver Neukum
2015-07-02 15:57 ` Jeremy White
2015-07-02 18:46 ` Oliver Neukum
2015-07-02 19:02 ` Jeremy White
2015-07-02 19:59 ` Alan Stern
2015-07-02 20:06 ` Jeremy White
2015-07-02 20:20 ` Alan Stern
2015-07-03 8:51 ` Krzysztof Opasiak
2015-07-03 14:04 ` Alan Stern
2015-07-06 8:20 ` Oliver Neukum
2015-07-06 20:14 ` Jeremy White
2015-07-06 20:22 ` Alan Stern
[not found] ` <mnlh2b$1cs$1@ger.gmane.org>
2015-07-22 14:03 ` Jeremy White
2015-07-22 14:34 ` Greg KH
2015-07-22 16:55 ` Jeremy White
2015-07-22 17:59 ` Sean O. Stalley
2015-07-23 0:20 ` Jeremy White
2015-12-09 22:32 ` Jeremy White
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150630234805.GB13573@kroah.com \
--to=greg@kroah.com \
--cc=hdegoede@redhat.com \
--cc=jwhite@codeweavers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=spice-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®