From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752923AbbGABIy (ORCPT ); Tue, 30 Jun 2015 21:08:54 -0400 Received: from mail.kernel.org ([198.145.29.136]:58101 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751772AbbGABIs (ORCPT ); Tue, 30 Jun 2015 21:08:48 -0400 Date: Tue, 30 Jun 2015 18:08:45 -0700 From: Jaegeuk Kim To: nick Cc: cm224.lee@samsung.com, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] f2fs:Make the function check_dnode have a return type of bool Message-ID: <20150701010845.GC1496@jaegeuk-mac02.mot.com> References: <1435608421-5951-1-git-send-email-xerofoify@gmail.com> <20150701005037.GA1496@jaegeuk-mac02.mot.com> <55933AB1.1050002@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55933AB1.1050002@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 30, 2015 at 08:56:17PM -0400, nick wrote: > > > On 2015-06-30 08:50 PM, Jaegeuk Kim wrote: > > Hi, > > > > On Mon, Jun 29, 2015 at 04:07:01PM -0400, Nicholas Krause wrote: > >> This makes the function check_dnode have a return type of bool > >> due to this particular function only ever returning either one > >> or zero as its return value. > >> > >> Signed-off-by: Nicholas Krause > >> --- > >> fs/f2fs/gc.c | 10 +++++----- > >> 1 file changed, 5 insertions(+), 5 deletions(-) > >> > >> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > >> index e1e7361..ebd4c6c 100644 > >> --- a/fs/f2fs/gc.c > >> +++ b/fs/f2fs/gc.c > >> @@ -487,7 +487,7 @@ block_t start_bidx_of_node(unsigned int node_ofs, struct f2fs_inode_info *fi) > >> return bidx * ADDRS_PER_BLOCK + ADDRS_PER_INODE(fi); > >> } > >> > >> -static int check_dnode(struct f2fs_sb_info *sbi, struct f2fs_summary *sum, > >> +static bool check_dnode(struct f2fs_sb_info *sbi, struct f2fs_summary *sum, > > > > Then, what about bool is_data_alive() ? > > > > Thanks, > > > There is no function of this name in my searching with either lxr or cscope. > Either my tools aren't finding it or the function you are requesting I make > bool has been removed. > Nick I meant; if you want to change the return type as a bool type, what about changing its function name too? (e.g., is_data_alive())