From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753140AbbGEJOG (ORCPT ); Sun, 5 Jul 2015 05:14:06 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34081 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750751AbbGEJNt (ORCPT ); Sun, 5 Jul 2015 05:13:49 -0400 Date: Sun, 5 Jul 2015 08:57:27 +0200 From: Jean Delvare To: Guenter Roeck Cc: Constantine Shulyupin , open@suse.de, lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] hwmon: (nct7802) Add pwm control Message-ID: <20150705085727.23e25d08@endymion.delvare> In-Reply-To: <55982124.2070500@roeck-us.net> References: <1436021854-13072-1-git-send-email-const@MakeLinux.com> <55982124.2070500@roeck-us.net> Organization: SUSE Linux X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.23; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 04 Jul 2015 11:08:36 -0700, Guenter Roeck wrote: > Hi Constantine, > > On 07/04/2015 07:57 AM, Constantine Shulyupin wrote: > > Added fan output control registers. > > Modes of operation are PWM (default) and DC. > > > > Another note: Since you mention DC vs. pwm mode, have you > considered adding pwm[123]_mode attributes to report the > selected mode ? If you do, please make sure these attributes are read-only. Thanks, -- Jean Delvare SUSE L3 Support