From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754608AbbGFLSA (ORCPT <rfc822;w@1wt.eu>);
	Mon, 6 Jul 2015 07:18:00 -0400
Received: from bombadil.infradead.org ([198.137.202.9]:36183 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754129AbbGFLR5 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 6 Jul 2015 07:17:57 -0400
Date: Mon, 6 Jul 2015 13:17:48 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org,
        Jiri Olsa <jolsa@redhat.com>, Stephane Eranian <eranian@google.com>,
        mathieu.poirier@linaro.org, Pawel Moll <pawel.moll@arm.com>
Subject: Re: [RFC V2 PATCH 1/4] perf: Add PERF_RECORD_SWITCH to indicate
 context switches
Message-ID: <20150706111748.GB3644@twins.programming.kicks-ass.net>
References: <1435927962-32417-1-git-send-email-adrian.hunter@intel.com>
 <1435927962-32417-2-git-send-email-adrian.hunter@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1435927962-32417-2-git-send-email-adrian.hunter@intel.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 03, 2015 at 03:52:39PM +0300, Adrian Hunter wrote:
> +static void perf_event_switch(struct task_struct *task,
> +			      struct task_struct *next_prev, bool out)
> +{

The patch looks good, however with perf_pmu_sched_task() we have bool
sched_in, and here we have bool out.

Maybe make that consistent?