From: Byungchul Park <byungchul.park@lge.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] sched: apply ifdef CONFIG_SMP to meaningful code only on SMP system
Date: Mon, 6 Jul 2015 21:05:53 +0900 [thread overview]
Message-ID: <20150706120553.GC31287@byungchulpark-X58A-UD3R> (raw)
In-Reply-To: <20150706112746.GD3644@twins.programming.kicks-ass.net>
On Mon, Jul 06, 2015 at 01:27:46PM +0200, Peter Zijlstra wrote:
> On Sun, Jul 05, 2015 at 06:43:31PM +0900, byungchul.park@lge.com wrote:
> > From: Byungchul Park <byungchul.park@lge.com>
> >
> > account_numa_dequeue and manipulating se->group_node are meaningful only on SMP
>
> Clearly the data element exists for !SMP and you didn't fix that.
> Also, try and do this without adding more #ifdef.
yes.
it will be better if it can be done without #ifdef.
i will try it.
thank you very much :)
byungchul
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2015-07-06 12:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-05 9:43 byungchul.park
2015-07-06 11:27 ` Peter Zijlstra
2015-07-06 12:05 ` Byungchul Park [this message]
2016-08-25 6:56 ` Byungchul Park
2016-08-26 3:00 ` Byungchul Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150706120553.GC31287@byungchulpark-X58A-UD3R \
--to=byungchul.park@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®