From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752899AbbGFR1p (ORCPT ); Mon, 6 Jul 2015 13:27:45 -0400 Received: from mail-bn1on0085.outbound.protection.outlook.com ([157.56.110.85]:19277 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750936AbbGFR1j (ORCPT ); Mon, 6 Jul 2015 13:27:39 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; lists.infradead.org; dkim=none (message not signed) header.d=none; Date: Mon, 6 Jul 2015 10:27:27 -0700 From: =?utf-8?B?U8O2cmVu?= Brinkmann To: Moritz Fischer CC: jassisinghbrar@gmail.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, michal.simek@xilinx.com, akpm@linux-foundation.org, gregkh@linuxfoundation.org, mchehab@osg.samsung.com, arnd@arndb.de, joe@perches.com, jingoohan1@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCHv6 1/2] dts: Adding docs for Xilinx LogiCORE IP mailbox driver. Message-ID: <20150706172727.GH6550@xsjsorenbubuntu> References: <1436202963-16922-1-git-send-email-moritz.fischer@ettus.com> <1436202963-16922-2-git-send-email-moritz.fischer@ettus.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1436202963-16922-2-git-send-email-moritz.fischer@ettus.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21658.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD019;1:ZbJ780uzau+5s8Hh2K9rp4SYx7C6Xii5klrvMHB89SliJKX8OQscv03cYAbrXUwNb/lxByKogRY7mDIAEqXAtK6z/5p13phD8DETdn80W3gc3VBWHJtjPwgjAnYTfk/BwP5A5P4bamk55QSbDrXnXq5TPejbmFXgJEorUpYNZJVXa377fhdQbi+OqlZDSv0B4ot9jFp7H6AkKPd5AuQ7ceKgWoR/4YAyCsHkxTGOopmVBXh/SZeeB/ddxXOgtZj17HUby/QOvaBF9+88xvTvmXt4khRsy8rYETyzKwkS6c55WzoNhsF6c2/i6qvNoIJv X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(24454002)(51704005)(377424004)(189002)(199003)(36386004)(50466002)(4001350100001)(33656002)(54356999)(76176999)(92566002)(110136002)(106466001)(47776003)(85182001)(189998001)(5001960100002)(50986999)(77156002)(62966003)(23676002)(46102003)(57986006)(76506005)(63266004)(77096005)(2950100001)(15975445007)(83506001)(87936001)(6806004)(33716001)(19580405001)(19580395003)(86362001)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1AFFO11HUB006;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;MLV:sfv;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11HUB006;2:JrCnxIfv+bL3lKWXtVlKwLKQbFLqmz9QkV/wrP9OEu7G2NFyviju9GCVWa0ZDORt;3:4wi13pN9DCWPj+yYJsrrDVkxStqkNSbO/yu520JFNO//ylv3s4ir8fdIInSBmwABw92XEctDFSjkx3dOeax0Xu684CJ0TSv+/fcUlUIicXAo+VeuNuv23fBU+6L0qbqDThJ4VA6P3c9xxybJmpL4kR0hdyo5IFgbqG0SoOtGZyrnGdysHejcn7Wjbywma+o6hqc7fkAL/vBK2v/O0t0eVbiDxoWIoFJo7pCNGjXocU4=;20:L+Mvot5GN8i00R4ZOiTCxTUb6SzsdmNrWTAcGovC9xoxeZPs692wlAjUZV2lm7X7iul2StVkNm0+tPnAl0YwFTr/gh226VHiGc6q81YjLu9hDZsknInUsFFvQFYfgYecVE70UmCQon5YjcuvOuTBkvAF/LQr28oDnpnNDcuykuCysLHCoZFyMBa7cbJLj5Og5kEgRU6xMyfUOqFX/Yi2C1iTkHonjaRyJK7kT2JlAMJRuMcTLR40+gnu1ezJW6p6+Pi91C9jrL4tnKwRHS2oeWpLM7xR7/o3lPqqoyQHe3rcJOiV3GRiggRKYAn9+SOr3V3PbOhd7Bo14Bud9hVVSBllcUnsa1RDwRYf0fV93Kz6JubDliyeHP4qTh5kkIULAY1qN9EbeZe+Y2w4Nu8psfxaRA3ZNpouM66eAVZmhxvHyOQOza6XuKY+1rPRkAxM0ftc/09Ey9T25e64ZWs0zLKaQoa2QbfbSvO5/lCxotZIAEL1ZHWPu5eNuxe5ERO6 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN1AFFO11HUB006; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:BN1AFFO11HUB006;BCL:0;PCL:0;RULEID:;SRVR:BN1AFFO11HUB006; X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11HUB006;4:LLyEz0IBcaJ3lUayb2L1dOkv/Ohc6rCJQ0zXymdPwFKx0xPQ098z/afSuhux7BTEI9tOgmoT8J3v4SYsrZ2mLi4V8ZZ1RbwduSbhpCEwTH3pDQ/2H+72x5XwwGNip++MXYVyTEdFeWSqpJPVRz2w7sOuzD9wFcWXdQFXQxroJhc4sFDndycfCTSke72u3mQsW6pf08rOsXR5LroSeyy++Un+aCec5+5EgMbUJfUQVWmGL+mK7GCHqJldvxc6Ysort2ez7CsGrP4seWveHxh5e4oUIBOVGiF5J2eH8J5R6OM= X-Forefront-PRVS: 06290ECA9D X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjFBRkZPMTFIVUIwMDY7MjM6TGNPa2ltTThlN3ZkdXFyVGp2T0dBNlBW?= =?utf-8?B?MWRZYTRSVkUxMVh0SGg3WlYzRmEzcmt0M2V3eUJKV2ZxTjlSdmlkZG5IZDNm?= =?utf-8?B?YStzOHNoNWdNNExlcTVLeWdQdWVCemZ6QnU3bWFsQ1pWeksrSzVOUXZHMUlD?= =?utf-8?B?K1FSMXVNQTVqYm9ocjBIRHdCUWI3MGJUSGQydlVOdFBaY2x1dDkzQlZkZ1NM?= =?utf-8?B?UUMyNjFTMXJDczhGWElwWHF2NHJ6YWJPUnlIaEFvMFNPc2RCci9nbDlHL2Ux?= =?utf-8?B?L04vL29pUkxBcFFNcHVvY1I0Y2xWdDVESzgrUTcvWjhHdGlFZFJrYjNBZUU0?= =?utf-8?B?MW1XdEZjZUNVa3U3eWtxSUZCZmdreVl2b2JzakJGUUY5TEpFb0pvUWxhWjMy?= =?utf-8?B?UHFhcUNCTlJxUW9BVWRSRGlYR2lOaEVlZm9PVW0vZFEvb09RM3Y1TlJCSGJX?= =?utf-8?B?b2pINkhoeDlVL25DTzkzUGZ0M2ZmMURsaXJ3bHRZa28rWjMvalYwM1FxeUtP?= =?utf-8?B?QVhvZ2RkMUZkMXFaNWVDTnN2Z0pFUG85RVlCWm1BQVZBc0lCNTZpTVlZUThy?= =?utf-8?B?dm1ISXF4bi9kM1B4Z1dVVWErRkUrTDUycndQcjVWOEhPVUo1dEhQM3gxait1?= =?utf-8?B?TGNsZkdIVXZ6ZG1pUUZDYTZOZVAzdXBsUzJvVlNVVVdsdTdOdUVwczdrcEpB?= =?utf-8?B?VXM2YXlRMWYzMGQzcmlUQWlDb0gwV0YxZlNEakljR1BmVlhQcmZXWnJCc3RJ?= =?utf-8?B?cU0yUXBBSUQvRldQc0pHWTBPY2FaeTdRTlQzL1lKZ0VDQ2xNRnoyL1ZCMVJp?= =?utf-8?B?MlM2YWwzdUpvMjZtQ3VrZHkzUHlrTkVMMEtvYkN3NmpqczVldmMzd2x3K05h?= =?utf-8?B?NE5QdUlvcHlwdm1uZk5STytQSlhOdjRoeXhPZXRHRGFYNmtTNTYxc0FHdGNK?= =?utf-8?B?NE93anNNbTNUYlV3R3pmb09qUXFTcW9zYm1BWlJuenY1NHdVRmdHbGE2bXNF?= =?utf-8?B?VVE5anZDV1lIaWJrdnNJcHZFcVc1ZkY2WFVxQWtVMGhuUlB2WkVBVEV2cnM2?= =?utf-8?B?YVZZSHZ4azZhT1hKSFZ6NjA0eERSbEJRU29EN1ZLcWRsRUREMmJKVHRnK1ZN?= =?utf-8?B?RVJJdm1nM0pTRVcrSHUzb2dTUEt6L2ZFb1QweDdPK3lzNk45YVdFOEVMeFVy?= =?utf-8?B?VTlsVGE0S0FHWmpIdFZBMmsxNXBoWTNmM25UZ3RvejhZa0FGem01WFBkVUdw?= =?utf-8?B?dG5jQ1U3UjhUbXY2VjMreitCTm90ZTZnWXpSL1NsTWhkcWtmMzFtbXVUdDg2?= =?utf-8?B?eDUveW1jeGJNcTYrVXl1R2pmeFpaaTFlMjhLT2cvT29ob3lLNHZJSmJPNEFV?= =?utf-8?B?L0t3RlJaQXhISmNvOEZ1RG9CWDYrRDhSK1F4VDBjYkE9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11HUB006;5:Y0WBhLOcWzdpEjsbgjNGCe1myT7w/8kzHzofY0uClIcc395BVWvf1VVpgbKTl4TKvsKODjHt74bv/iEsxO7M2gZYM/aGdOrejDxgP0IUeFdLJh/OQtIOHeGWlzyc33bzLZf5adaTtyKMN8cVoMl5Wg==;24:rD0W7DPRP83A8crg/MtjKrB2ZTnOng8GjVUnJ/EZumyVvcX/jmibTQmLJIJLUaxCQ6I4/MJiwKDhCutejWzFOXIDw7nem5RE+MsyI6tpeq0= X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2015 17:27:37.0344 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1AFFO11HUB006 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-07-06 at 10:16AM -0700, Moritz Fischer wrote: > Signed-off-by: Moritz Fischer > Acked-by: Michal Simek > --- > .../devicetree/bindings/mailbox/xilinx-mailbox.txt | 44 ++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mailbox/xilinx-mailbox.txt > > diff --git a/Documentation/devicetree/bindings/mailbox/xilinx-mailbox.txt b/Documentation/devicetree/bindings/mailbox/xilinx-mailbox.txt > new file mode 100644 > index 0000000..97b81f8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mailbox/xilinx-mailbox.txt > @@ -0,0 +1,44 @@ > +Xilinx Mailbox Driver > +===================== > + > +Required properties: > +- compatible : "xlnx,mailbox-2.1". > +- reg : physical base address of the mailbox and length of > + memory mapped region. > +- #mbox-cells : common mailbox binding property to identify the number > + of cells required for the mailbox specifier, should be 0 > +- clocks : phandle to clock provider > +- clock-names : must be 'mbox' > + > +Optional properties: > +- interrupt-parent : interrupt source phandle > +- interrupts : interrupt number, The interrupt specifier format > + depends on the interrupt controller parent. > + > +Example: > + mbox: mailbox@40400000 { > + compatible = "xlnx,mailbox-2.1"; > + reg = <0x40400000 0x100>; > + interrupt-parent = <&intc>; > + interrupts = <5>; > + #mbox-cells = <0>; > + clocks = <&clkc 15>; > + clock-names = "mbox"; > + }; > + > +Mailbox client > +=============== > +"mboxes" and the optional "mbox-names" (please see > +Documentation/devicetree/bindings/mailbox/mailbox.txt for details). Each value > +of the mboxes property should contain a phandle to the mailbox controller > +device node and second argument is the channel index. It must be 0 (hardware > +support only one channel). The equivalent "mbox-names" property value can be > +used to give a name to the communication channel to be used by the client user. > + > +Example: > + mclient0: mclient0@400 { > + compatible = "client-1.0"; > + reg = <0x400 0x10>; > + mbox-names = "mbox"; > + mboxes = <&mbox 0>; Sorry, to bring this up again, but I'm confused regarding the #mbox-cells thing. Above it says #mbox-cells is 0. In that case, shouldn't the 'mboxes' property not only be '<&mbox>'? Moreover, the generic mailbox bindings (https://www.kernel.org/doc/Documentation/devicetree/bindings/mailbox/mailbox.txt) mandate #mbox-cells to be at least 1. Does something need to be aligned here? Sören