From: Joerg Roedel <jroedel@suse.de>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
guangrong.xiao@linux.intel.com, alex.williamson@redhat.com,
ogerlitz@mellanox.com, amirv@mellanox.com
Subject: Re: [PATCH 1/3] KVM: SVM: use NPT page attributes
Date: Tue, 7 Jul 2015 15:23:14 +0200 [thread overview]
Message-ID: <20150707132314.GJ16233@suse.de> (raw)
In-Reply-To: <1436273894-42501-2-git-send-email-pbonzini@redhat.com>
Hi Paolo,
On Tue, Jul 07, 2015 at 02:58:12PM +0200, Paolo Bonzini wrote:
> +static void svm_set_guest_pat(struct vcpu_svm *svm, u64 *g_pat)
> +{
> + struct kvm_vcpu *vcpu = &svm->vcpu;
> +
> + /* Unlike Intel, AMD takes the guest's CR0.CD into account.
> + *
> + * AMD doesn't have snooping control in the IOMMU, but if the guest
The AMD IOMMU has snooping control, its just called 'Force Coherent'
there. The AMD IOMMU driver always sets the FC bit in the page tables.
Joerg
next prev parent reply other threads:[~2015-07-07 13:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 12:58 [RFC/RFT PATCH 0/3] KVM: x86: full virtualization of guest MTRR Paolo Bonzini
2015-07-07 12:58 ` [PATCH 1/3] KVM: SVM: use NPT page attributes Paolo Bonzini
2015-07-07 13:23 ` Joerg Roedel [this message]
2015-07-07 12:58 ` [PATCH 2/3] KVM: SVM: Sync g_pat with guest-written PAT value Paolo Bonzini
2015-07-07 12:58 ` [PATCH 3/3] KVM: x86: apply guest MTRR virtualization on host reserved pages Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150707132314.GJ16233@suse.de \
--to=jroedel@suse.de \
--cc=alex.williamson@redhat.com \
--cc=amirv@mellanox.com \
--cc=guangrong.xiao@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome