From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757228AbbGGNZw (ORCPT ); Tue, 7 Jul 2015 09:25:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57799 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755460AbbGGNZo (ORCPT ); Tue, 7 Jul 2015 09:25:44 -0400 Date: Tue, 7 Jul 2015 09:25:42 -0400 From: Mike Snitzer To: Mikulas Patocka Cc: "Alasdair G. Kergon" , Edward Thornber , dm-devel@redhat.com, David Rientjes , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/7] dm: introduce dm_kvmalloc Message-ID: <20150707132542.GA15860@redhat.com> References: <20150706134750.GA31600@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 07 2015 at 8:50am -0400, Mikulas Patocka wrote: > > > On Mon, 6 Jul 2015, Mike Snitzer wrote: > > > In general I like what you've done with this patchset _except_ I'm not > > seeing why dm_kvmalloc() should be in DM at all. It should probably be > > elevated to an kvmalloc() export from mm/util.c and include/linux/mm.h > > along-side kvfree(). > > If memory management maintainers agree to put it into mm core, it would be > nice. If not, put it into device mapper. Please rework your patches so that the mm changes are split out into clean patch(es) at the start of the series. Please cc Andrew and David on posting v2. Also, please chain the reply so that the patchset is properly threaded.