From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757388AbbGGNxj (ORCPT ); Tue, 7 Jul 2015 09:53:39 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:42871 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756987AbbGGNxc (ORCPT ); Tue, 7 Jul 2015 09:53:32 -0400 Date: Tue, 7 Jul 2015 14:53:17 +0100 From: Mark Brown To: Lee Jones Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, lgirdwood@gmail.com Message-ID: <20150707135317.GR2887@sirena.org.uk> References: <1436173112-21397-1-git-send-email-lee.jones@linaro.org> <1436173112-21397-9-git-send-email-lee.jones@linaro.org> <20150707133155.GL2887@sirena.org.uk> <20150707134545.GH3182@x1> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6eUvXotnMb6+obQB" Content-Disposition: inline In-Reply-To: <20150707134545.GH3182@x1> X-Cookie: Only fools are quoted. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 91.125.27.234 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [RESEND 08/10] regulator: pwm-regulator: Add support for continuous-voltage X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --6eUvXotnMb6+obQB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jul 07, 2015 at 02:45:45PM +0100, Lee Jones wrote: > On Tue, 07 Jul 2015, Mark Brown wrote: > > On Mon, Jul 06, 2015 at 09:58:30AM +0100, Lee Jones wrote: > > > + tmp = max_duty_cycle - min_mV * max_duty_cycle / vdiff; > > > + pwm_code = tmp + max_duty_cycle * volt_mV / vdiff; > > These need some brackets to be clear that they're correct. > As you rightly pointed out, this stuff gets over-written in the next > patch, although I have no problem with providing some bracketing if > required. Yes, please. --6eUvXotnMb6+obQB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVm9nNAAoJECTWi3JdVIfQBYMH/09597fQODYPVcOzuYg2PNXb fhO5mUBlkBvC5OPr7uLKERRzOHaSBcMWCU0gCBeiGHrWuEVAmCw13n2OnPmHE53u VhVXeh1/L44YLQP6Dfg5utlF/I6cT+agRuZg46LsOjFHAKIEeyJtXZPPygvh2w4v CqQhwnBQg0J9yEQnpF8fs/p1QkqnB6EKzW0zo0qK4bG5QVnVu1amEMgVvRwms9GC gMK10KlHZnAemt5WK8C2YuqdCYnWG/CAieEepgdHoSzlZRucn2ihxllRMZ/zaMu4 895qiZQKsH/8QCNuaNQKByTjZW/aPGEJww5quDo238w1YVKjqlipQcbi5mhemig= =IskM -----END PGP SIGNATURE----- --6eUvXotnMb6+obQB--