From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933599AbbGGWlP (ORCPT ); Tue, 7 Jul 2015 18:41:15 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59918 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932851AbbGGWlH (ORCPT ); Tue, 7 Jul 2015 18:41:07 -0400 Date: Tue, 7 Jul 2015 15:41:06 -0700 From: Andrew Morton To: Nicholas Krause Cc: khalasa@piap.pl, bigeasy@linutronix.de, paulmcquad@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm:Change unlabeled block of code to a else block in the function dma_pool_free Message-Id: <20150707154106.cd2f4e024a11c02993f02298@linux-foundation.org> In-Reply-To: <1436225431-5880-1-git-send-email-xerofoify@gmail.com> References: <1436225431-5880-1-git-send-email-xerofoify@gmail.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 6 Jul 2015 19:30:31 -0400 Nicholas Krause wrote: > This fixes the unlabeled block of code after the if statement that > executes if the passed dma variable of type dma_addr_t minus the > structure pointer page's dma member is equal to the variable offset > into a else block as this block should run when the if statement check > > Signed-off-by: Nicholas Krause > --- > mm/dmapool.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/dmapool.c b/mm/dmapool.c > index fd5fe43..ce7ff4b 100644 > --- a/mm/dmapool.c > +++ b/mm/dmapool.c > @@ -434,8 +434,7 @@ void dma_pool_free(struct dma_pool *pool, void *vaddr, dma_addr_t dma) > "dma_pool_free %s, %p (bad vaddr)/%Lx\n", > pool->name, vaddr, (unsigned long long)dma); > return; > - } > - { > + } else { > unsigned int chain = page->offset; > while (chain < pool->allocation) { > if (chain != offset) { This patch has no effect?