From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933432AbbGGTxw (ORCPT ); Tue, 7 Jul 2015 15:53:52 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:41610 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933398AbbGGTxb (ORCPT ); Tue, 7 Jul 2015 15:53:31 -0400 Date: Tue, 7 Jul 2015 21:53:17 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Nicholas Krause Cc: davem@davemloft.net, claudiu.manoil@freescale.com, haokexin@gmail.com, matei.pavaluca@freescale.com, jingchang.lu@freescale.com, tobias@waldekranz.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] freescale:Make the function gfar_configure_coalescing_all static Message-ID: <20150707195317.GJ9671@pengutronix.de> References: <1436298573-28541-1-git-send-email-xerofoify@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1436298573-28541-1-git-send-email-xerofoify@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 07, 2015 at 03:49:33PM -0400, Nicholas Krause wrote: > This makes the function gfar_configure_coalescing_all static > and removes its function prototype from the header file, gianfar.h really? Looking at the diffstat I dare to disagree. > due to this function only ever being called in its definition and > declaration file of gainfar.c. > > Signed-off-by: Nicholas Krause > --- > drivers/net/ethernet/freescale/gianfar.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |