From: David Miller <davem@davemloft.net>
To: phil@nwl.cc
Cc: tgraf@suug.ch, sparclinux@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
herbert@gondor.apana.org.au, daniel@iogearbox.net,
geert@linux-m68k.org, mroos@linux.ee
Subject: Re: [PATCH v2] rhashtable: fix for resize events during table walk
Date: Wed, 08 Jul 2015 14:55:06 -0700 (PDT) [thread overview]
Message-ID: <20150708.145506.1343225462680114617.davem@davemloft.net> (raw)
In-Reply-To: <1436190680-21887-1-git-send-email-phil@nwl.cc>
From: Phil Sutter <phil@nwl.cc>
Date: Mon, 6 Jul 2015 15:51:20 +0200
> If rhashtable_walk_next detects a resize operation in progress, it jumps
> to the new table and continues walking that one. But it misses to drop
> the reference to it's current item, leading it to continue traversing
> the new table's bucket in which the current item is sorted into, and
> after reaching that bucket's end continues traversing the new table's
> second bucket instead of the first one, thereby potentially missing
> items.
>
> This fixes the rhashtable runtime test for me. Bug probably introduced
> by Herbert Xu's patch eddee5ba ("rhashtable: Fix walker behaviour during
> rehash") although not explicitly tested.
>
> Fixes: eddee5ba ("rhashtable: Fix walker behaviour during rehash")
> Signed-off-by: Phil Sutter <phil@nwl.cc>
Applied and queued up for -stable, thanks.
next prev parent reply other threads:[~2015-07-08 21:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 13:51 Phil Sutter
2015-07-06 13:53 ` Herbert Xu
2015-07-08 21:55 ` David Miller [this message]
2015-07-14 21:35 ` mroos
2015-07-14 21:48 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150708.145506.1343225462680114617.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=daniel@iogearbox.net \
--cc=geert@linux-m68k.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mroos@linux.ee \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=sparclinux@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®