From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759376AbbGHSAZ (ORCPT ); Wed, 8 Jul 2015 14:00:25 -0400 Received: from smtprelay0195.hostedemail.com ([216.40.44.195]:43676 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755744AbbGHSAW (ORCPT ); Wed, 8 Jul 2015 14:00:22 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2553:2559:2562:2904:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3871:3872:3873:3874:4184:4250:4321:5007:6119:6261:6742:7875:7903:10004:10226:10400:10848:10967:11232:11658:11914:12296:12517:12519:12740:13069:13095:13255:13311:13357:14096:14097:21060:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: tail16_3d09219185a5b X-Filterd-Recvd-Size: 2604 Date: Wed, 8 Jul 2015 14:00:17 -0400 From: Steven Rostedt To: Joe Perches Cc: "Luis R. Rodriguez" , Gavin Hu , Petr Mladek , linux-kernel@vger.kernel.org, Alex Elder , Peter Hurley , Tejun Heo , cxie4@marvell.com, cldu@marvell.com, xjian@marvell.com, fswu@marvell.com, Jan Kara Subject: Re: printk: preempt_disable with long time resulting in softlockup/RCU stall issues Message-ID: <20150708140017.6c96d4d5@gandalf.local.home> In-Reply-To: <1436376929.2682.85.camel@perches.com> References: <20150708081334.GJ32664@pathway.suse.cz> <20150708170402.GZ7021@wotan.suse.de> <1436376929.2682.85.camel@perches.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 08 Jul 2015 10:35:29 -0700 Joe Perches wrote: > On Wed, 2015-07-08 at 19:04 +0200, Luis R. Rodriguez wrote: > > On Wed, Jul 08, 2015 at 05:08:35PM +0800, Gavin Hu wrote: > > > Hi, > > > > > > Yes. We should disable the printk_limit feature when panic to avoid missing > > > messages. > > > > Sounds like you have been looking into it and have a good idea of what you > > want to do, why not try it and send some RFC patches ? > > > > While at it, then we could consider doing different things depending on the > > message type. KERN_EMERG would disable preemption, whereas KERN_INFO may not be > > so critical to require it. > > That might be a bit difficult to implement with complete correctness > given KERN_EMERG use and continuation lines. > Or just have the current context determine what to do. If printk() was called with preemption or interrupts disabled, it flushes the full buffer before returning, otherwise it allows the writes to console be preempted. That would be great for -rt, as currently we don't even allow printk() to write out if called from a interrupt disabled context, unless the console it writes to is marked as preempt safe (serial console is unfortunately not). -- Steve