mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: kan.liang@intel.com
Cc: acme@kernel.org, jolsa@kernel.org, namhyung@kernel.org,
	ak@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC V2 3/5] perf,tool: partial time support
Date: Wed, 8 Jul 2015 16:48:15 +0200	[thread overview]
Message-ID: <20150708144815.GB13619@krava.redhat.com> (raw)
In-Reply-To: <1436264345-12085-4-git-send-email-kan.liang@intel.com>

On Tue, Jul 07, 2015 at 06:19:03AM -0400, kan.liang@intel.com wrote:

SNIP

>  
> @@ -705,13 +732,14 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts)
>  	/*
>  	 * When the user explicitely disabled time don't force it here.
>  	 */
> -	if (opts->sample_time &&
> +	if (sample_time &&
>  	    (!perf_missing_features.sample_id_all &&
>  	    (!opts->no_inherit || target__has_cpu(&opts->target) || per_cpu)))
>  		perf_evsel__set_sample_bit(evsel, TIME);
>  
>  	if (opts->raw_samples && !evsel->no_aux_samples) {
> -		perf_evsel__set_sample_bit(evsel, TIME);
> +		if (sample_time)
> +			perf_evsel__set_sample_bit(evsel, TIME);
>  		perf_evsel__set_sample_bit(evsel, RAW);
>  		perf_evsel__set_sample_bit(evsel, CPU);

these bits no longer apply due to:
   3abebc55d70b perf record: Let user have timestamps with per-thread recording

please rebase to latest acme's perf/core

thanks,
jirka

  reply	other threads:[~2015-07-08 14:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-07 10:19 [PATCH RFC V2 0/5] partial callgrap and " kan.liang
2015-07-07 10:19 ` [PATCH RFC V2 1/5] perf,tools: introduce OPT_CALLBACK_SET/OPT_CALLBACK_NOOPT_SET kan.liang
2015-07-08 14:41   ` Jiri Olsa
2015-07-07 10:19 ` [PATCH RFC V2 2/5] perf/documentation: Add description for period kan.liang
2015-07-07 10:19 ` [PATCH RFC V2 3/5] perf,tool: partial time support kan.liang
2015-07-08 14:48   ` Jiri Olsa [this message]
2015-07-12 13:22   ` Jiri Olsa
2015-07-13 18:59     ` Liang, Kan
2015-07-07 10:19 ` [PATCH RFC V2 4/5] perf,tool: partial callgrap support kan.liang
2015-07-07 10:19 ` [PATCH RFC V2 5/5] perf,tests: Add tests to callgrap and time parse kan.liang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150708144815.GB13619@krava.redhat.com \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®