From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754589AbbGISBk (ORCPT ); Thu, 9 Jul 2015 14:01:40 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:44417 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753648AbbGISBh (ORCPT ); Thu, 9 Jul 2015 14:01:37 -0400 Date: Thu, 09 Jul 2015 11:01:35 -0700 (PDT) Message-Id: <20150709.110135.225522890258902682.davem@davemloft.net> To: vivien.didelot@savoirfairelinux.com Cc: andrew@lunn.ch, netdev@vger.kernel.org, sfeldma@gmail.com, jiri@resnulli.us, f.fainelli@gmail.com, linux@roeck-us.net, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com Subject: Re: [PATCH v4 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit From: David Miller In-Reply-To: <894793886.88178.1436375596747.JavaMail.zimbra@savoirfairelinux.com> References: <1436303900-24259-1-git-send-email-vivien.didelot@savoirfairelinux.com> <20150708143805.GA32208@lunn.ch> <894793886.88178.1436375596747.JavaMail.zimbra@savoirfairelinux.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 09 Jul 2015 11:01:36 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vivien Didelot Date: Wed, 8 Jul 2015 13:13:16 -0400 (EDT) > You're right. There's a single operation to clear the STU and VTU. I > will send a follow-up patch to send this command during the switch > setup. Fix known bugs in the patch series, within the patch series, since it hasn't been merged yet. Don't say "I'll fix this bug later", because we can fix it now. Also as others have noted, this patch set creates an intermediate state where functionality is effectively broken. So it is illogical to knowingly merge this patch series as-is. You'll have to piece together all of the changes necessary such that the series is fully bisectable, which means at every patch along the way things function properly and do not break. Thanks.