From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752671AbbGII4J (ORCPT ); Thu, 9 Jul 2015 04:56:09 -0400 Received: from mail-wg0-f48.google.com ([74.125.82.48]:35663 "EHLO mail-wg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750728AbbGII4F (ORCPT ); Thu, 9 Jul 2015 04:56:05 -0400 Date: Thu, 9 Jul 2015 10:56:02 +0200 From: Michal Hocko To: David Rientjes Cc: Andrew Morton , Jakob Unterwurzacher , linux-mm@kvack.org, LKML Subject: Re: [PATCH 3/4] mm, oom: organize oom context into struct Message-ID: <20150709085602.GC13872@dhcp22.suse.cz> References: <1436360661-31928-1-git-send-email-mhocko@suse.com> <1436360661-31928-4-git-send-email-mhocko@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 08-07-15 16:38:25, David Rientjes wrote: > On Wed, 8 Jul 2015, Michal Hocko wrote: > > > From: David Rientjes > > > > There are essential elements to an oom context that are passed around to > > multiple functions. > > > > Organize these elements into a new struct, struct oom_context, that > > specifies the context for an oom condition. > > > > This patch introduces no functional change. > > > > [mhocko@suse.cz: s@oom_control@oom_context@] > > [mhocko@suse.cz: do not initialize on stack oom_context with NULL or 0] > > Signed-off-by: David Rientjes > > Signed-off-by: Michal Hocko > > I hate to appear to be nacking my own patch, but it was correct when > included in my series What is incorrect in this patch? -- Michal Hocko SUSE Labs