From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754210AbbGINVd (ORCPT ); Thu, 9 Jul 2015 09:21:33 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:39814 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753510AbbGINVZ (ORCPT ); Thu, 9 Jul 2015 09:21:25 -0400 Date: Thu, 9 Jul 2015 15:21:20 +0200 From: Markus Pargmann To: Hermann Lauer Cc: nbd-general@lists.sourceforge.net, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Michal Belczyk Subject: Re: [PATCH v4.0 for testing] nbd: Fix timeout detection Message-ID: <20150709132120.GJ7573@pengutronix.de> References: <20150423144313.GI19764@lemon.iwr.uni-heidelberg.de> <1429860933-22517-1-git-send-email-mpa@pengutronix.de> <20150424144158.GF30067@lemon.iwr.uni-heidelberg.de> <20150709080651.GA25210@lemon.iwr.uni-heidelberg.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="AptwxgnoZDC4KQWS" Content-Disposition: inline In-Reply-To: <20150709080651.GA25210@lemon.iwr.uni-heidelberg.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 15:05:43 up 14 days, 7:28, 119 users, load average: 0.40, 0.45, 0.43 User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: mpa@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --AptwxgnoZDC4KQWS Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Hermann, On Thu, Jul 09, 2015 at 10:06:52AM +0200, Hermann Lauer wrote: > Hello Markus, >=20 > > On Fri, Apr 24, 2015 at 09:35:33AM +0200, Markus Pargmann wrote: > > > At the moment the nbd timeout just detects hanging tcp operations. Th= is > > > is not enough to detect a hanging or bad connection as expected of a > > > timeout. > > ... > > > Cc: Michal Belczyk > > > Cc: Hermann Lauer > > > Signed-off-by: Markus Pargmann > > > [mpa: Backported to 4.0] > > >=20 > > > Signed-off-by: Markus Pargmann > > > --- > > >=20 > > > This patch is only for testing at the moment. I will backport the fin= al patch > > > for the stable tree at the end. > >=20 > > tested with 4.0 - timeout works as expected after > > disconnecting the ethernet. > > No hang or unexpected kernel message. >=20 > still no problems so far - may I ask if the patch made his way upstream ? > If you already submitted it, knowing the commit would be nice to tell > it to the Debian maintainers. Thanks for reporting. Sorry for the delay, but I queued the patch for 4.3 yesterday. The patch will not go into the stable kernel trees. This is somehow more of a feature than a bug. The timeout works as it was designed. This patch just makes the timeout handling more intuitive for the user. I hope this is fine for you. Best regards, Markus --=20 Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --AptwxgnoZDC4KQWS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVnnVQAAoJEEpcgKtcEGQQhoAP/1UbsMbGS0lHVJcmFFqyWiQt ru7cwIRBqGjBBHOfHTARxu9gixT7jXM3BlnkVA+txvs+2jZpqeCJrUM2iSEyb4k+ zx5ZgrI7HC0lbBr3LMETlG5JEetF2lmAYnXfSnoEQP0F5qj4dZZPxdBPKE3g+Q9I eXWUEO7P5zqBttuJVYfEfkRT9PGoE2HdA37k7jca6ZQJwOIbgxIl/XIr1TvoJTeO co8rZVCw0qhU/Loa8TlCPKHNwS541/oRLBhKH9AUKbxC0y4TxZJQ4oLvz5i0/r2y RAQ6pvRp7oKGoRD1DwEdLs/v3VWn8sMopTm1HopRkMb6EodArLgEbaIgTbqEHOCO WnrjPitz/MgIPOMUhTBFEkgwQQcQTsnIKqKeeTVLYuihASdSk3axjbSTr8lAop// ZmSaHk/9N4QVNY0ImLn/Ovay7ONB+hW4R4R6COfi/zcej2k7B89tCiRnTqZBkyU1 VZ25u8+IHCA4NgvNSLbCMUgqjoP9g5Ly+91rj4Fy6g0Zdxlgzl+xri8z2V91DILv np4TsIiS8lOZ7drpAS2uCCIMkWJimVdr+QZnUgTgU647tC/f2RzLpuNAA68M+rfT Ti/7+6g9aL8DXBAXr5YEW4fIXDXbev64x3ETb27//e9FGhETjGKVGOJW0u1rOEVT DUTPqkq35rRlzlTUFYjz =fpzg -----END PGP SIGNATURE----- --AptwxgnoZDC4KQWS--