From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754034AbbGIS0l (ORCPT ); Thu, 9 Jul 2015 14:26:41 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:48101 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753790AbbGIS0f (ORCPT ); Thu, 9 Jul 2015 14:26:35 -0400 Date: Thu, 9 Jul 2015 11:26:25 -0700 From: Guenter Roeck To: Paul Bolle Cc: "David S. Miller" , netdev@vger.kernel.org, Andrew Lunn , Florian Fainelli , linux-kernel@vger.kernel.org, "Aleksey S. Kazantsev" Subject: Re: [PATCH] dsa: mv88e6352/mv88e6xxx: Add support for Marvell 88E6320 and 88E6321 Message-ID: <20150709182625.GB788@roeck-us.net> References: <1436326695-18666-1-git-send-email-linux@roeck-us.net> <1436432003.20619.102.camel@tiscali.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436432003.20619.102.camel@tiscali.nl> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 09, 2015 at 10:53:23AM +0200, Paul Bolle wrote: > On di, 2015-07-07 at 20:38 -0700, Guenter Roeck wrote: > > --- a/drivers/net/dsa/mv88e6352.c > > +++ b/drivers/net/dsa/mv88e6352.c > > > -MODULE_ALIAS("platform:mv88e6352"); > > MODULE_ALIAS("platform:mv88e6172"); > > +MODULE_ALIAS("platform:mv88e6176"); > > +MODULE_ALIAS("platform:mv88e6320"); > > +MODULE_ALIAS("platform:mv88e6321"); > > +MODULE_ALIAS("platform:mv88e6352"); > > Naive question: there are quite a few similar MODULE_ALIAS() macros in > drivers/net/dsa. That is, macros using "platform:mv88e6[...]". But I > couldn't find the struct platform_device's that would, in short, fire > off the corresponding "MODALIAS=platform:mv88e6[...]" uevent when > they're created. Where should I look for those struct platform_device's? > Good question. The devices are instantiated from the dsa driver (net/dsa/dsa.c). I don't really know if the above aliases serve a practical purpose. Does anyone else know ? Guenter