From: Mark Brown <broonie@kernel.org>
To: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, lgirdwood@gmail.com,
sameo@linux.intel.com, lee.jones@linaro.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] regulator: 88pm800: Add dev_info to show probe success status
Date: Thu, 9 Jul 2015 20:05:47 +0100 [thread overview]
Message-ID: <20150709190547.GQ11162@sirena.org.uk> (raw)
In-Reply-To: <1436445692-10656-4-git-send-email-vaibhav.hiremath@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 530 bytes --]
On Thu, Jul 09, 2015 at 06:11:32PM +0530, Vaibhav Hiremath wrote:
> This patch adds dev_info line at the end of probe function, to
> clearly put status of regulator probe on console. Useful during
> development, specially to check bootlog.
> + dev_info(&pdev->dev, "Regulator registered ...\n");
> return 0;
No, this is pure noise - all you're doing is slowing down boot for users
with no content. Think about what would happen if every driver did
this. The core already displays the constraints when things are
registered.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-07-09 19:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 12:41 [PATCH 0/3] regulator: 88pm800: Add 88pm860 regulator support Vaibhav Hiremath
2015-07-09 12:41 ` [PATCH 1/3] " Vaibhav Hiremath
2015-07-09 13:59 ` Lee Jones
2015-07-09 18:35 ` Mark Brown
2015-07-09 12:41 ` [PATCH 2/3] regulator: 88pm800: fix LDO vsel_mask value Vaibhav Hiremath
2015-07-09 19:04 ` Mark Brown
2015-07-10 12:07 ` Vaibhav Hiremath
2015-07-10 0:25 ` Applied "regulator: 88pm800: fix LDO vsel_mask value" to the regulator tree Mark Brown
2015-07-09 12:41 ` [PATCH 3/3] regulator: 88pm800: Add dev_info to show probe success status Vaibhav Hiremath
2015-07-09 19:05 ` Mark Brown [this message]
2015-07-10 12:11 ` Vaibhav Hiremath
2015-07-09 19:36 ` Valdis.Kletnieks
2015-07-09 22:05 ` Mark Brown
2015-07-10 12:12 ` Vaibhav Hiremath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150709190547.GQ11162@sirena.org.uk \
--to=broonie@kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=vaibhav.hiremath@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®