From: Oleg Nesterov <oleg@redhat.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Ingo Molnar <mingo@kernel.org>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] uprobes: use vm_special_mapping to name the xol vma
Date: Fri, 10 Jul 2015 00:03:41 +0200 [thread overview]
Message-ID: <20150709220341.GC15485@redhat.com> (raw)
In-Reply-To: <CALCETrWoFdim09Z6-9UNj3JJHYd-3wnBq-WaJ9m=5DV20T-Ovw@mail.gmail.com>
On 07/09, Andy Lutomirski wrote:
>
> On Thu, Jul 9, 2015 at 2:44 PM, Oleg Nesterov <oleg@redhat.com> wrote:
> > Change xol_add_vma() to use _install_special_mapping(), this way
> > we can name the vma installed by uprobes. Currently it looks like
> > private anonymous mapping, this is confusing and complicates the
> > debugging. With this change /proc/$pid/maps reports "[uprobes]".
>
> I think this will cause core dumps to include it as a side effect. Is
> that okay?
Yes, I even mentioned this in 0/3... I'll move thhis note into the
changelog in v2.
Thanks!
Oleg.
next prev parent reply other threads:[~2015-07-09 22:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 21:44 uprobes: minor fixes + " Oleg Nesterov
2015-07-09 21:44 ` [PATCH 1/3] uprobes: fix the usage of install_special_mapping() Oleg Nesterov
2015-07-09 21:49 ` Andy Lutomirski
2015-07-09 22:02 ` Oleg Nesterov
2015-07-09 22:12 ` Andy Lutomirski
2015-07-09 21:44 ` [PATCH 2/3] uprobes: use vm_special_mapping to name the xol vma Oleg Nesterov
2015-07-09 21:50 ` Andy Lutomirski
2015-07-09 22:03 ` Oleg Nesterov [this message]
2015-07-09 21:44 ` [PATCH 3/3] uprobes: fix the waitqueue_active() check in xol_free_insn_slot() Oleg Nesterov
2015-07-09 22:25 ` [PATCH v2 0/3] uprobes: minor fixes + name the xol vma Oleg Nesterov
2015-07-09 22:25 ` [PATCH v2 1/3] uprobes: fix the usage of install_special_mapping() Oleg Nesterov
2015-07-09 22:25 ` [PATCH v2 2/3] uprobes: use vm_special_mapping to name the xol vma Oleg Nesterov
2015-07-09 22:25 ` [PATCH v2 3/3] uprobes: fix the waitqueue_active() check in xol_free_insn_slot() Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150709220341.GC15485@redhat.com \
--to=oleg@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome