From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933403AbbGJVSP (ORCPT ); Fri, 10 Jul 2015 17:18:15 -0400 Received: from mail-wg0-f51.google.com ([74.125.82.51]:34795 "EHLO mail-wg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932579AbbGJVSA (ORCPT ); Fri, 10 Jul 2015 17:18:00 -0400 Date: Sat, 11 Jul 2015 00:17:56 +0300 From: Alexey Dobriyan To: akpm@linux-foundation.org Cc: joe@perches.com, linux-kernel@vger.kernel.org Subject: [PATCH -mm] parse_integer: add checkpatch.pl notice Message-ID: <20150710211756.GA10625@p183.telecom.by> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * remove check for strict_strto*(), they were fully removed long ago, * add check for simple_strto*(), suggest replacements sscanf() is a bit icky to suggest because it accepts arbitrary amount of whitespace before any integer conversion, but assume programmer knows such twist and don't use sscanf() where real strictness is required (yes, sure...). Signed-off-by: Alexey Dobriyan --- scripts/checkpatch.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -5498,10 +5498,10 @@ sub process { "consider using a completion\n" . $herecurr); } -# recommend kstrto* over simple_strto* and strict_strto* - if ($line =~ /\b((simple|strict)_(strto(l|ll|ul|ull)))\s*\(/) { +# simple_strto*() is deprecated + if ($line =~ /\b(simple_strto(l|ll|ul|ull))\s*\(/) { WARN("CONSIDER_KSTRTO", - "$1 is obsolete, use k$3 instead\n" . $herecurr); + "$1 is obsolete, use parse_integer(), kstrto*(), kstrto*_from_user(), sscanf() instead\n" . $herecurr); } # check for __initcall(), use device_initcall() explicitly or more appropriate function please