mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: vivien.didelot@savoirfairelinux.com
Cc: netdev@vger.kernel.org, linux@roeck-us.net, andrew@lunn.ch,
	linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com
Subject: Re: [PATCH v2] net: dsa: mv88e6xxx: add write access to debugfs regs file
Date: Sat, 11 Jul 2015 19:08:22 -0700 (PDT)	[thread overview]
Message-ID: <20150711.190822.1431177169987395247.davem@davemloft.net> (raw)
In-Reply-To: <1092744390.7730.1436639772848.JavaMail.zimbra@savoirfairelinux.com>

From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Date: Sat, 11 Jul 2015 14:36:12 -0400 (EDT)

> In the meantime, this is really useful for development. i.e. ensuring a good
> switchdev/DSA interaction without being able to read and write directly the
> hardware VLAN table, is a bit a PITA. A dynamic debugfs looked appropriate.

For "development" you can hack the driver, add tracepoints, or use
another mechanism anyone hacking the kernel (which by definition
someone doing "development" is doing) can do.

I do not buy any of your arguments, and you really miss the grand
opportunity to export the knobs and values in a way which are going
to:

1) Be useful to users

2) Be usable by any similar DSA driver, not just _yours_

So please stop this myopic narrow thinking when you add facilities for
development or export values.  Think of the big picture and long term,
not just your personal perceived immediate needs of today.

Thanks.

  reply	other threads:[~2015-07-12  2:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-09 21:13 Vivien Didelot
2015-07-11  6:01 ` David Miller
2015-07-11 18:36   ` Vivien Didelot
2015-07-12  2:08     ` David Miller [this message]
2015-07-13  1:39       ` Vivien Didelot
2015-07-13  3:25         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150711.190822.1431177169987395247.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=andrew@lunn.ch \
    --cc=kernel@savoirfairelinux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=netdev@vger.kernel.org \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®