From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751405AbbGLVAi (ORCPT <rfc822;w@1wt.eu>);
	Sun, 12 Jul 2015 17:00:38 -0400
Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.228]:49241 "EHLO
	cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1750941AbbGLVAh (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 12 Jul 2015 17:00:37 -0400
Date: Sun, 12 Jul 2015 17:01:17 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Rusty Russell <rusty@rustcorp.com.au>,
        David Howells <dhowells@redhat.com>, Ming Lei <ming.lei@canonical.com>,
        Seth Forshee <seth.forshee@canonical.com>,
        Kyle McMartin <kyle@kernel.org>, "Luis R. Rodriguez" <mcgrof@suse.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] firmware: Fix dereferencing NULL pointer of
 fw_priv->buf->fw_id
Message-ID: <20150712170117.4017400f@grimm.local.home>
In-Reply-To: <CA+55aFzg2uX38JXK9oAU=t_4YoEfB4hQjyCVpEwDQ0dTpwfEQg@mail.gmail.com>
References: <20150712144949.7e984c63@gandalf.local.home>
	<CA+55aFzg2uX38JXK9oAU=t_4YoEfB4hQjyCVpEwDQ0dTpwfEQg@mail.gmail.com>
X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-RR-Connecting-IP: 107.14.168.142:25
X-Cloudmark-Score: 0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 12 Jul 2015 13:50:19 -0700
Linus Torvalds <torvalds@linux-foundation.org> wrote:

> On Sun, Jul 12, 2015 at 11:49 AM, Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > Unfortunately, this caused the following BUG:
> 
> I'm hoping you didn't waste too much time on this.

Well, not that much. I was able to automate the bisects. But it did
cause me to waste time in my own testing, which needs to be restarted
because this bug caused my tests to fail.

> 
> Because check commit 6f957724b94c, which fixes the NULL pointer
> dereference _and_ the lack of proper locking.
> 

Thanks, I'll take note.

-- Steve