From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753894AbbGMUo6 (ORCPT ); Mon, 13 Jul 2015 16:44:58 -0400 Received: from www.linutronix.de ([62.245.132.108]:55899 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753550AbbGMUoz (ORCPT ); Mon, 13 Jul 2015 16:44:55 -0400 Message-Id: <20150712225929.580825411@linutronix.de> User-Agent: quilt/0.63-1 Date: Mon, 13 Jul 2015 20:44:47 -0000 From: Thomas Gleixner To: LKML Cc: Jiang Liu , Lee Jones , Samuel Ortiz , Russell King , Julia Lawall Subject: [patch 2/9] mfd/htc-egpio: Consolidate chained IRQ handler install/remove References: <20150712225758.573960291@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Disposition: inline; filename=mfd-htc-egpio-Consolidate-chained-IRQ-handler-instal.patch X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Chained irq handlers usually set up handler data as well. We now have a function to set both under irq_desc->lock. Replace the two calls with one. Search and conversion was done with coccinelle: Reported-by: Russell King Signed-off-by: Thomas Gleixner Cc: Julia Lawall Cc: Samuel Ortiz Cc: Lee Jones --- drivers/mfd/htc-egpio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: tip/drivers/mfd/htc-egpio.c =================================================================== --- tip.orig/drivers/mfd/htc-egpio.c +++ tip/drivers/mfd/htc-egpio.c @@ -353,8 +353,8 @@ static int __init egpio_probe(struct pla set_irq_flags(irq, IRQF_VALID | IRQF_PROBE); } irq_set_irq_type(ei->chained_irq, IRQ_TYPE_EDGE_RISING); - irq_set_handler_data(ei->chained_irq, ei); - irq_set_chained_handler(ei->chained_irq, egpio_handler); + irq_set_chained_handler_and_data(ei->chained_irq, + egpio_handler, ei); ack_irqs(ei); device_init_wakeup(&pdev->dev, 1);