mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Jiang Liu <jiang.liu@linux.intel.com>,
	Lee Jones <lee.jones@linaro.org>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Russell King <rmk+kernel@arm.linux.org.uk>,
	Julia Lawall <Julia.Lawall@lip6.fr>
Subject: [patch 3/9] mfd/jz4740: Consolidate chained IRQ handler install/remove
Date: Mon, 13 Jul 2015 20:44:49 -0000	[thread overview]
Message-ID: <20150712225929.659159843@linutronix.de> (raw)
In-Reply-To: <20150712225758.573960291@linutronix.de>

[-- Attachment #1: mfd-jz4740-Consolidate-chained-IRQ-handler-install-r.patch --]
[-- Type: text/plain, Size: 1424 bytes --]

Chained irq handlers usually set up handler data as well. We now have
a function to set both under irq_desc->lock. Replace the two calls
with one.

Search and conversion was done with coccinelle:

Reported-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Samuel Ortiz <sameo@linux.intel.com>
Cc: Lee Jones <lee.jones@linaro.org>
---
 drivers/mfd/jz4740-adc.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Index: tip/drivers/mfd/jz4740-adc.c
===================================================================
--- tip.orig/drivers/mfd/jz4740-adc.c
+++ tip/drivers/mfd/jz4740-adc.c
@@ -277,8 +277,7 @@ static int jz4740_adc_probe(struct platf
 
 	adc->gc = gc;
 
-	irq_set_handler_data(adc->irq, gc);
-	irq_set_chained_handler(adc->irq, jz4740_adc_irq_demux);
+	irq_set_chained_handler_and_data(adc->irq, jz4740_adc_irq_demux, gc);
 
 	writeb(0x00, adc->base + JZ_REG_ADC_ENABLE);
 	writeb(0xff, adc->base + JZ_REG_ADC_CTRL);
@@ -308,8 +307,7 @@ static int jz4740_adc_remove(struct plat
 
 	irq_remove_generic_chip(adc->gc, IRQ_MSK(5), IRQ_NOPROBE | IRQ_LEVEL, 0);
 	kfree(adc->gc);
-	irq_set_handler_data(adc->irq, NULL);
-	irq_set_chained_handler(adc->irq, NULL);
+	irq_set_chained_handler_and_data(adc->irq, NULL, NULL);
 
 	iounmap(adc->base);
 	release_mem_region(adc->mem->start, resource_size(adc->mem));



  parent reply	other threads:[~2015-07-13 20:59 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-13 20:44 [patch 0/9] mfd: Interrupt cleanups and API change preparation Thomas Gleixner
2015-07-13 20:44 ` [patch 1/9] mfd/ezx-pcap: Consolidate chained IRQ handler install/remove Thomas Gleixner
2015-07-27 15:56   ` [tip:irq/core] " tip-bot for Thomas Gleixner
2015-07-28  8:04   ` [patch 1/9] " Lee Jones
2015-07-13 20:44 ` [patch 2/9] mfd/htc-egpio: " Thomas Gleixner
2015-07-27 15:56   ` [tip:irq/core] " tip-bot for Thomas Gleixner
2015-07-28  8:04   ` [patch 2/9] " Lee Jones
2015-07-13 20:44 ` Thomas Gleixner [this message]
2015-07-27 15:57   ` [tip:irq/core] mfd/jz4740: " tip-bot for Thomas Gleixner
2015-07-28  8:04   ` [patch 3/9] " Lee Jones
2015-07-13 20:44 ` [patch 4/9] mfd/pm8921: " Thomas Gleixner
2015-07-27 15:57   ` [tip:irq/core] " tip-bot for Thomas Gleixner
2015-07-28  8:05   ` [patch 4/9] " Lee Jones
2015-07-13 20:44 ` [patch 5/9] mfd/t7l66xb: " Thomas Gleixner
2015-07-27 15:57   ` [tip:irq/core] " tip-bot for Thomas Gleixner
2015-07-28  8:05   ` [patch 5/9] " Lee Jones
2015-07-13 20:44 ` [patch 6/9] mfd/tc6393xb: " Thomas Gleixner
2015-07-27 15:58   ` [tip:irq/core] " tip-bot for Thomas Gleixner
2015-07-28  8:05   ` [patch 6/9] " Lee Jones
2015-07-13 20:44 ` [patch 7/9] mfd: Use irq_desc_get_xxx() to avoid redundant lookup of irq_desc Thomas Gleixner
2015-07-27 15:58   ` [tip:irq/core] " tip-bot for Jiang Liu
2015-07-28  8:05   ` [patch 7/9] " Lee Jones
2015-07-13 20:44 ` [patch 8/9] mfd/ucb1x00: Prepare ucb1x00_irq for irq argument removal Thomas Gleixner
2015-07-27 15:58   ` [tip:irq/core] " tip-bot for Thomas Gleixner
2015-07-28  8:06   ` [patch 8/9] " Lee Jones
2015-07-13 20:44 ` [patch 9/9] mfd/max899x: Avoid redundant irq_data lookup Thomas Gleixner
2015-07-27 15:59   ` [tip:irq/core] " tip-bot for Thomas Gleixner
2015-07-28  8:06   ` [patch 9/9] " Lee Jones
2015-07-27 16:20 ` [patch 0/9] mfd: Interrupt cleanups and API change preparation Lee Jones
2015-07-28  8:17 ` Lee Jones
2015-07-28  8:42   ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150712225929.659159843@linutronix.de \
    --to=tglx@linutronix.de \
    --cc=Julia.Lawall@lip6.fr \
    --cc=jiang.liu@linux.intel.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®