From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752665AbbGMSjs (ORCPT ); Mon, 13 Jul 2015 14:39:48 -0400 Received: from smtprelay0014.hostedemail.com ([216.40.44.14]:49203 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751892AbbGMSjr (ORCPT ); Mon, 13 Jul 2015 14:39:47 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3867:3871:4321:5007:6261:7576:7774:7875:10004:10400:10562:10848:10967:11026:11232:11473:11658:11914:12296:12438:12517:12519:12555:12740:13069:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: cake32_72527cab0c350 X-Filterd-Recvd-Size: 2304 Date: Mon, 13 Jul 2015 14:39:44 -0400 From: Steven Rostedt To: Umesh Tiwari Cc: mingo@redhat.com, linux-kernel@vger.kernel.org, gupta.namit@samsung.com, pankaj.m@samsung.com, Himanshu Maithani Subject: Re: [PATCH] ftrace: add tracing_thresh to function profile Message-ID: <20150713143944.020ef25d@gandalf.local.home> In-Reply-To: <1434972488-8571-1-git-send-email-umesh.t@samsung.com> References: <1434972488-8571-1-git-send-email-umesh.t@samsung.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 Jun 2015 16:58:08 +0530 Umesh Tiwari wrote: > From: Himanshu Maithani > > This patch extends tracing_thresh functionality to function profile tracer. > If tracing_thresh is set, print those entries only, > whose average is > tracing thresh. > This should also have a Signed-off-by from Himanshu Miathani. If possible. -- Steve > Signed-off-by: Umesh Tiwari > --- > kernel/trace/ftrace.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c > index 4f22802..7a48a67 100644 > --- a/kernel/trace/ftrace.c > +++ b/kernel/trace/ftrace.c > @@ -600,13 +600,19 @@ static int function_stat_show(struct seq_file *m, void *v) > goto out; > } > > + /* moved above to avoid printing values < thresh */ > +#ifdef CONFIG_FUNCTION_GRAPH_TRACER > + avg = rec->time; > + do_div(avg, rec->counter); > + if (tracing_thresh && (avg < tracing_thresh)) > + goto out; > +#endif > + > kallsyms_lookup(rec->ip, NULL, NULL, NULL, str); > seq_printf(m, " %-30.30s %10lu", str, rec->counter); > > #ifdef CONFIG_FUNCTION_GRAPH_TRACER > seq_puts(m, " "); > - avg = rec->time; > - do_div(avg, rec->counter); > > /* Sample standard deviation (s^2) */ > if (rec->counter <= 1)