mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Omar Sandoval <osandov@fb.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] trace-cmd: annotate function durations like the kernel
Date: Mon, 13 Jul 2015 14:43:19 -0400	[thread overview]
Message-ID: <20150713144319.393b5015@gandalf.local.home> (raw)
In-Reply-To: <05162f43fb6322f4c46722403449ffdab134e3d2.1435170824.git.osandov@fb.com>

On Wed, 24 Jun 2015 11:36:54 -0700
Omar Sandoval <osandov@fb.com> wrote:

> Since kernel commit, 8e1e1df29d83 ("tracing: Add additional marks to
> signal very large time deltas") the kernel annotates durations longer
> than 1000 usecs with # and longer than 1 sec with $. Update trace-cmd
> report to be consistent with it.


Thanks, applied.

(sorry for the late notice). I'll be pushing this up later today.

-- Steve

> 
> Signed-off-by: Omar Sandoval <osandov@fb.com>
> ---
> Just a minor cosmetic issue I noticed. Thanks!
> 
>  trace-ftrace.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/trace-ftrace.c b/trace-ftrace.c
> index bdf11ce4c2dd..636b08b5cdef 100644
> --- a/trace-ftrace.c
> +++ b/trace-ftrace.c
> @@ -147,11 +147,19 @@ static void print_graph_overhead(struct trace_seq *s,
>  	if (duration == ~0ULL)
>  		return (void)trace_seq_printf(s, "  ");
>  
> -	/* Duration exceeded 100 msecs */
> +	/* Duration exceeded 1 sec */
> +	if (duration > 1000000000ULL)
> +		return (void)trace_seq_printf(s, "$ ");
> +
> +	/* Duration exceeded 1000 usecs */
> +	if (duration > 1000000ULL)
> +		return (void)trace_seq_printf(s, "# ");
> +
> +	/* Duration exceeded 100 usecs */
>  	if (duration > 100000ULL)
>  		return (void)trace_seq_printf(s, "! ");
>  
> -	/* Duration exceeded 10 msecs */
> +	/* Duration exceeded 10 usecs */
>  	if (duration > 10000ULL)
>  		return (void)trace_seq_printf(s, "+ ");
>  


  reply	other threads:[~2015-07-13 18:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-24 18:36 Omar Sandoval
2015-07-13 18:43 ` Steven Rostedt [this message]
2015-07-29 17:20   ` Omar Sandoval
2015-08-03 19:44     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150713144319.393b5015@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=osandov@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®