mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org, pbonzini@redhat.com
Subject: Re: [PATCH] vhost: fix build failure on SPARC
Date: Mon, 13 Jul 2015 23:41:18 +0200	[thread overview]
Message-ID: <20150713234118.1781495a@igors-macbook-pro.local> (raw)
In-Reply-To: <20150713231850-mutt-send-email-mst@redhat.com>

On Mon, 13 Jul 2015 23:19:59 +0300
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Mon, Jul 13, 2015 at 08:15:30PM +0200, Igor Mammedov wrote:
> > while on x86 target vmalloc.h is included indirectly through
> > other heaedrs, it's not included on SPARC.
> > Fix issue by including vmalloc.h directly from vhost.c
> > like it's done in vhost/net.c
> > 
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> 
> It's your vmalloc patch that introduces the issue, right?
> I squashed this fix into that one.
Thanks!
yep, that right. I've sent this patch as reply to vmalloc
patch that introduced issue but forgot to add commit it
that introduced issue.

> 
> You can just send fixup! patches in cases like this
> in the future, or at least mention the commit that
> breaks the build.
ok, I'll do it next time.

> 
> 
> > ---
> >  drivers/vhost/vhost.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
> > index 9a68e2e..a9fe859 100644
> > --- a/drivers/vhost/vhost.c
> > +++ b/drivers/vhost/vhost.c
> > @@ -22,6 +22,7 @@
> >  #include <linux/file.h>
> >  #include <linux/highmem.h>
> >  #include <linux/slab.h>
> > +#include <linux/vmalloc.h>
> >  #include <linux/kthread.h>
> >  #include <linux/cgroup.h>
> >  #include <linux/module.h>
> > -- 
> > 1.8.3.1


  reply	other threads:[~2015-07-13 21:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-02 13:08 [PATCH v4 0/2] vhost: support more than 64 memory regions Igor Mammedov
2015-07-02 13:08 ` [PATCH v4 1/2] vhost: extend memory regions allocation to vmalloc Igor Mammedov
2015-07-13 18:15   ` [PATCH] vhost: fix build failure on SPARC Igor Mammedov
2015-07-13 20:19     ` Michael S. Tsirkin
2015-07-13 21:41       ` Igor Mammedov [this message]
2015-07-02 13:08 ` [PATCH v4 2/2] vhost: add max_mem_regions module parameter Igor Mammedov
2015-07-16 11:05   ` Igor Mammedov
2015-07-08 12:51 ` [PATCH v4 0/2] vhost: support more than 64 memory regions Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150713234118.1781495a@igors-macbook-pro.local \
    --to=imammedo@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®