From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753100AbbGNCLa (ORCPT ); Mon, 13 Jul 2015 22:11:30 -0400 Received: from 202-89-161-53.static.dsl.amnet.net.au ([202.89.161.53]:55036 "EHLO GateKeeper.xayto.local" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753039AbbGNCL2 (ORCPT ); Mon, 13 Jul 2015 22:11:28 -0400 Date: Tue, 14 Jul 2015 09:36:37 +0000 From: Craig Inches To: Joe Perches Cc: Craig , gregkh@linuxfoundation.org, arve@android.com, riandrews@android.com, mitchelh@codeaurora.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: android: ion: Fix Style Issue Message-ID: <20150714093637.GA15958@Morat.xayto.local> References: <1436808581-14864-1-git-send-email-craig.inches@xayto.net> <1436787742.2711.98.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436787742.2711.98.camel@perches.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 13, 2015 at 04:42:22AM -0700, Joe Perches wrote: > On Mon, 2015-07-13 at 17:29 +0000, Craig wrote: > > Modified style issue in ion.c. Missing empty line after a definition > > > > Signed-off-by: Craig > > --- > > drivers/staging/android/ion/ion.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c > > index 6f48112..e44f5e6 100644 > > --- a/drivers/staging/android/ion/ion.c > > +++ b/drivers/staging/android/ion/ion.c > > @@ -1106,6 +1106,7 @@ struct dma_buf *ion_share_dma_buf(struct ion_client *client, > > struct ion_buffer *buffer; > > struct dma_buf *dmabuf; > > bool valid_handle; > > + > > DEFINE_DMA_BUF_EXPORT_INFO(exp_info); > > > > mutex_lock(&client->lock); > > checkpatch false positive. Thanks for the feed back. > Fixed in checkpatch by > https://lkml.org/lkml/2015/7/1/383 and the reference to the fix. Cheers, Craig