From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753049AbbGNQ2z (ORCPT <rfc822;w@1wt.eu>);
	Tue, 14 Jul 2015 12:28:55 -0400
Received: from cantor2.suse.de ([195.135.220.15]:33491 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752734AbbGNQ2x (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 14 Jul 2015 12:28:53 -0400
Date: Tue, 14 Jul 2015 18:28:50 +0200
From: Michal Kubecek <mkubecek@suse.cz>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
        linux-api@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Patrick McHardy <kaber@trash.net>,
        Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
        "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH nf-next] netfilter: nf_ct_sctp: minimal multihoming
 support
Message-ID: <20150714162850.GA8478@unicorn.suse.cz>
References: <20150714122311.8DA8EA0C9A@unicorn.suse.cz>
 <20150714153847.GA3507@salvia>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150714153847.GA3507@salvia>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jul 14, 2015 at 05:38:47PM +0200, Pablo Neira Ayuso wrote:
> On Tue, Jul 14, 2015 at 02:23:11PM +0200, Michal Kubecek wrote:
> > @@ -658,6 +696,18 @@ static struct ctl_table sctp_sysctl_table[] = {
> >  		.mode		= 0644,
> >  		.proc_handler	= proc_dointvec_jiffies,
> >  	},
> > +	{
> > +		.procname	= "nf_conntrack_sctp_timeout_heartbeat_sent",
> > +		.maxlen		= sizeof(unsigned int),
> > +		.mode		= 0644,
> > +		.proc_handler	= proc_dointvec_jiffies,
> > +	},
> > +	{
> > +		.procname	= "nf_conntrack_sctp_timeout_heartbeat_acked",
> > +		.maxlen		= sizeof(unsigned int),
> > +		.mode		= 0644,
> > +		.proc_handler	= proc_dointvec_jiffies,
> > +	},
> >  	{ }
> >  };
> >  
> > @@ -705,6 +755,18 @@ static struct ctl_table sctp_compat_sysctl_table[] = {
> >  		.mode		= 0644,
> >  		.proc_handler	= proc_dointvec_jiffies,
> >  	},
> > +	{
> > +		.procname	= "ip_conntrack_sctp_timeout_heartbeat_sent",
> > +		.maxlen		= sizeof(unsigned int),
> > +		.mode		= 0644,
> > +		.proc_handler	= proc_dointvec_jiffies,
> > +	},
> > +	{
> > +		.procname	= "ip_conntrack_sctp_timeout_heartbeat_acked",
> > +		.maxlen		= sizeof(unsigned int),
> > +		.mode		= 0644,
> > +		.proc_handler	= proc_dointvec_jiffies,
> > +	},
> >  	{ }
> 
> I don't see the nla_policy updates for the netlink cttimeout
> interface.

I didn't realize those were needed. It means adding two entries to
sctp_timeout_nla_policy and two values to enum ctattr_timeout_sctp?
Or something else is also needed?

                                                        Michal Kubecek