From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755445AbbGOJmr (ORCPT ); Wed, 15 Jul 2015 05:42:47 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:32857 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753471AbbGOJmp (ORCPT ); Wed, 15 Jul 2015 05:42:45 -0400 Date: Wed, 15 Jul 2015 11:42:41 +0200 From: Michal Hocko To: David Rientjes Cc: Andrew Morton , Jakob Unterwurzacher , linux-mm@kvack.org, LKML Subject: Re: [PATCH 2/4] oom: Do not invoke oom notifiers on sysrq+f Message-ID: <20150715094240.GF5101@dhcp22.suse.cz> References: <1436360661-31928-1-git-send-email-mhocko@suse.com> <1436360661-31928-3-git-send-email-mhocko@suse.com> <20150709085505.GB13872@dhcp22.suse.cz> <20150710074032.GA7343@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 14-07-15 14:58:55, David Rientjes wrote: > On Fri, 10 Jul 2015, Michal Hocko wrote: > > > Shrinkers are there to reclaim and prevent from OOM. This API is a gray > > zone. It looks generic method for the notification yet it allows to > > prevent from oom killer. I can imagine somebody might abuse this > > interface to implement OOM killer policies. > > > > Anyway, I think it would be preferable to kill it altogether rather than > > play with its placing. It will always be a questionable API. > > > > Agreed. In such a case it would be still good to fix the bug fixed by this patch. -- Michal Hocko SUSE Labs