From: Hans-Christian Egtvedt <egtvedt@samfundet.no>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Haavard Skinnemoen <hskinnemoen@gmail.com>,
Jiang Liu <jiang.liu@linux.intel.com>,
Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [patch 2/3] avr32/at32ap: Use irq_set_handler_locked()
Date: Wed, 15 Jul 2015 13:52:09 +0200 [thread overview]
Message-ID: <20150715115209.GB32762@samfundet.no> (raw)
In-Reply-To: <20150713100606.448031045@linutronix.de>
Around Mon 13 Jul 2015 20:31:10 -0000 or thereabout, Thomas Gleixner wrote:
> Use irq_set_handler_locked() as it avoids a redundant lookup of the
> irq descriptor.
>
> Search and replacement was done with coccinelle.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Jiang Liu <jiang.liu@linux.intel.com>
> Cc: Julia Lawall <julia.lawall@lip6.fr>
> Cc: Haavard Skinnemoen <hskinnemoen@gmail.com>
> Cc: Hans-Christian Egtvedt <egtvedt@samfundet.no>
Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>
> ---
> arch/avr32/mach-at32ap/extint.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: tip/arch/avr32/mach-at32ap/extint.c
> ===================================================================
> --- tip.orig/arch/avr32/mach-at32ap/extint.c
> +++ tip/arch/avr32/mach-at32ap/extint.c
> @@ -128,9 +128,9 @@ static int eic_set_irq_type(struct irq_d
>
> irqd_set_trigger_type(d, flow_type);
> if (flow_type & (IRQ_TYPE_LEVEL_LOW | IRQ_TYPE_LEVEL_HIGH))
> - __irq_set_handler_locked(irq, handle_level_irq);
> + irq_set_handler_locked(d, handle_level_irq);
> else
> - __irq_set_handler_locked(irq, handle_edge_irq);
> + irq_set_handler_locked(d, handle_edge_irq);
>
> return IRQ_SET_MASK_OK_NOCOPY;
> }
--
mvh
Hans-Christian Egtvedt
next prev parent reply other threads:[~2015-07-15 11:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 20:31 [patch 0/3] avr32: Interrupt cleanups and API change preparation Thomas Gleixner
2015-07-13 20:31 ` [patch 1/3] avr32/at32ap: Consolidate chained IRQ handler install/remove Thomas Gleixner
2015-07-15 11:51 ` Hans-Christian Egtvedt
2015-07-27 6:12 ` [tip:irq/core] " tip-bot for Thomas Gleixner
2015-07-13 20:31 ` [patch 2/3] avr32/at32ap: Use irq_set_handler_locked() Thomas Gleixner
2015-07-15 11:52 ` Hans-Christian Egtvedt [this message]
2015-07-27 6:13 ` [tip:irq/core] " tip-bot for Thomas Gleixner
2015-07-13 20:31 ` [patch 3/3] avr32/irq: Use irq_desc_get_xxx() to avoid redundant lookup of irq_desc Thomas Gleixner
2015-07-27 6:13 ` [tip:irq/core] " tip-bot for Jiang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150715115209.GB32762@samfundet.no \
--to=egtvedt@samfundet.no \
--cc=hskinnemoen@gmail.com \
--cc=jiang.liu@linux.intel.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®