From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752643AbbGOPxH (ORCPT ); Wed, 15 Jul 2015 11:53:07 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:52796 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751895AbbGOPxG (ORCPT ); Wed, 15 Jul 2015 11:53:06 -0400 Date: Wed, 15 Jul 2015 16:52:54 +0100 From: Mark Brown To: Javier Martinez Canillas Cc: Krzysztof Kozlowski , Liam Girdwood , linux-kernel@vger.kernel.org Message-ID: <20150715155254.GR11162@sirena.org.uk> References: <1436883709-9337-1-git-send-email-javier@osg.samsung.com> <55A61C0E.4040707@osg.samsung.com> <20150715112730.GN11162@sirena.org.uk> <55A65621.4080109@osg.samsung.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Md45EOxnITciDgpR" Content-Disposition: inline In-Reply-To: <55A65621.4080109@osg.samsung.com> X-Cookie: Stay together, drag each other down. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] regulator: core: Fix memory leak in regulator_resolve_supply() X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Md45EOxnITciDgpR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jul 15, 2015 at 02:46:25PM +0200, Javier Martinez Canillas wrote: > On 07/15/2015 01:27 PM, Mark Brown wrote: > > using _regulator_get() I think. A separate, rarely used, path is likely > > to have this sort of issue. > Exactly, do you agree then that a try_module_get() is missing in set_supply()? > It is OK if I add that in the same patch in v2 or do you prefer that to be > in a separate patch? A separate patch would be better, or even better would be something that just replaces everything there with use of the same code path as _get() (thanks for volunteering!) but just adding the try_module_get() is fine for now. --Md45EOxnITciDgpR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVpoHVAAoJECTWi3JdVIfQKZsH/1/unFjAjaykHaKXWF7CuHbZ 9IIKSY8KYAyL7Qni2l7ARIE6cIO7Xp5X8S3QPlOtS4MQ8B+arVu/XSOXPslQ5wFG hmF+/soYnP9l9kGTuH8H6L7dfeNasYYXX7+SNnB6GX02MXr1ho6zsZDtNnfc9p9A +EhFBI2YIrymLxGUkJPHFRwKBgoN8QOcXkHN5jRwMcWZMnD8EHfLefngGeNO4XoW zT4B4HvNEd333xBUQ9KeUHe43FDa4svelmkgGuSDvaMRIbdV9L8B7Oy1i4yOUgO1 pU3zSs5lQIglU/RqRRCLN5h93fNQ6VHwTzNqjI5xRAx9Zq8Bv9rRmWlYn10qB6Y= =kPPi -----END PGP SIGNATURE----- --Md45EOxnITciDgpR--