From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752665AbbGOQxa (ORCPT ); Wed, 15 Jul 2015 12:53:30 -0400 Received: from mail-yk0-f171.google.com ([209.85.160.171]:34311 "EHLO mail-yk0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751502AbbGOQx3 (ORCPT ); Wed, 15 Jul 2015 12:53:29 -0400 Date: Wed, 15 Jul 2015 12:53:26 -0400 From: Tejun Heo To: Vivek Goyal Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, kernel-team@fb.com, avanzini.arianna@gmail.com Subject: Re: [PATCH 09/10] blkcg: move io_service_bytes and io_serviced stats into blkcg_gq Message-ID: <20150715165326.GF15934@mtj.duckdns.org> References: <1436724043-12986-1-git-send-email-tj@kernel.org> <1436724043-12986-10-git-send-email-tj@kernel.org> <20150714160908.GG10792@redhat.com> <20150715160425.GE15934@mtj.duckdns.org> <20150715162952.GA28818@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150715162952.GA28818@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Vivek. On Wed, Jul 15, 2015 at 12:29:52PM -0400, Vivek Goyal wrote: > Ok. I am personally little apprehensive of changing the meaning of > current stat, but I can live with it. Sure, if there are use cases which actually get impacted by this, reverting the original stats shouldn't be difficult. I don't think it's likely to matter tho. I mean, we even get sync / async distinction completely wrong in these stats. We're really pumping out garbage. > Can you please also update the blkio-controller.txt to reflect these > changes. I think following sections would require updation. > > blkio.throttle.io_serviced > blkio.throttle.io_service_bytes > > And we could mention in blkio.io_serviced that accounting is terms of > numeber of bios. Sure thing. Thanks. -- tejun