From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: linux-arm-kernel@lists.infradead.org, x86@kernel.org
Cc: Daniel Thompson <daniel.thompson@linaro.org>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH 0/3] Shared NMI backtracing support for ARM/x86
Date: Wed, 15 Jul 2015 21:39:12 +0100 [thread overview]
Message-ID: <20150715203911.GF7557@n2100.arm.linux.org.uk> (raw)
Back in September, I stumbled across a single CPU IRQs-off lockup of an
ARM SMP system, and decided to hack something together based on a much
older hacky implementation used with StrongARM CPUs from early 2000s.
This resulted in a copy of the x86 NMI backtrace code into ARM as it was
back then, and feedback indicated that it wasn't a good time to push
such an effort forward, as printk() in NMI context is dodgy.
Over time, the x86 code has had this problem addressed, and last week
I updated the patch which I've been carrying in my tree to move the
shared code out of arch/x86 into lib/ rather than duplicating it, and
switch the ARM implementation to use it.
Discussing this with Thomas Gliexner, he agreed to give it a test over
last weekend, and he has reported to me this evening "no explosion so
far". Since then, I've made a change to add the NOKPROBE_SYMBOL() to
the generic handler as per the x86 original code.
I'm aware that there are other competing implementations out there -
Daniel has one based on my patch from September time, but I don't think
that goes far enough with code sharing. I'm also partially aware of
an implementation from Petr too.
arch/arm/include/asm/irq.h | 5 ++
arch/arm/kernel/smp.c | 18 +++++
arch/x86/kernel/apic/hw_nmi.c | 133 ++--------------------------------
include/linux/nmi.h | 6 ++
lib/Makefile | 2 +-
lib/nmi_backtrace.c | 162 ++++++++++++++++++++++++++++++++++++++++++
6 files changed, 196 insertions(+), 130 deletions(-)
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
next reply other threads:[~2015-07-15 20:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 20:39 Russell King - ARM Linux [this message]
2015-07-15 20:39 ` [PATCH 1/3] nmi: create generic NMI backtrace implementation Russell King
2015-07-16 9:11 ` Daniel Thompson
2015-07-16 9:37 ` Russell King - ARM Linux
2015-07-16 9:51 ` Daniel Thompson
2015-07-25 14:42 ` Russell King - ARM Linux
2015-07-28 8:29 ` Daniel Thompson
2015-07-16 11:07 ` Thomas Gleixner
2015-07-15 20:39 ` [PATCH 2/3] nmi: x86: convert to generic nmi handler Russell King
2015-07-16 11:07 ` Thomas Gleixner
2015-07-15 20:39 ` [PATCH 3/3] ARM: add basic support for on-demand backtrace of other CPUs Russell King
2015-07-16 9:13 ` Daniel Thompson
2015-07-16 9:39 ` Russell King - ARM Linux
2015-07-16 9:55 ` [PATCH 0/3] Shared NMI backtracing support for ARM/x86 Daniel Thompson
2015-07-21 9:34 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150715203911.GF7557@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=daniel.thompson@linaro.org \
--cc=hpa@zytor.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®