From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753863AbbGOVbN (ORCPT ); Wed, 15 Jul 2015 17:31:13 -0400 Received: from mail-ie0-f181.google.com ([209.85.223.181]:34631 "EHLO mail-ie0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753480AbbGOVbL (ORCPT ); Wed, 15 Jul 2015 17:31:11 -0400 Date: Wed, 15 Jul 2015 14:31:07 -0700 From: Dmitry Torokhov To: Sebastian Reichel Cc: linux-input@vger.kernel.org, Michael Welling , Tony Lindgren , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] Input: tsc2005 - simplify drvdata acquisition Message-ID: <20150715213107.GB24393@dtor-ws> References: <1436962408-5206-1-git-send-email-sre@kernel.org> <1436962408-5206-4-git-send-email-sre@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436962408-5206-4-git-send-email-sre@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 15, 2015 at 02:13:27PM +0200, Sebastian Reichel wrote: > Do not convert device to spi_device just for getting > the driver data, since spi_get_drvdata() just calls > dev_get_drvdata(). Even though at the moment they all share the same data I consider them logically different and so would prefer not to substityte one for another. Thanks. -- Dmitry